From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhfWX-0007Wz-MU for qemu-devel@nongnu.org; Wed, 29 May 2013 08:30:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhfWT-00041e-2l for qemu-devel@nongnu.org; Wed, 29 May 2013 08:30:37 -0400 Message-ID: <51A5F4BF.90504@redhat.com> Date: Wed, 29 May 2013 14:29:51 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1369827271-20921-3-git-send-email-stefano.stabellini@eu.citrix.com> <51A5F06A.4040109@suse.de> In-Reply-To: <51A5F06A.4040109@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 3/3] xen_machine_pv: do not create a dummy CPU in machine->init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: aliguori@us.ibm.com, xen-devel@lists.xensource.com, Stefano Stabellini , qemu-devel@nongnu.org, qemu-stable@nongnu.org, anthony.perard@citrix.com, imammedo@redhat.com Il 29/05/2013 14:11, Andreas F=E4rber ha scritto: >> xen_machine_pv uses cpu_x86_init, therefore it has been broken. >> >> This patch fixes the problem by removing the dummy CPU creation >> altogether from xen_init_pv, relying on the fact that QEMU can now cop= e >> with a machine without an emulated CPU. >> >> This fix should be backported to QEMU 1.5. >> >> Signed-off-by: Stefano Stabellini >> CC: imammedo@redhat.com >> CC: qemu-stable@nongnu.org >=20 > Change looks okay, >=20 > Reviewed-by: Andreas F=E4rber >=20 > But for the future please avoid "this patch" in the commit message > (because later on it's a "commit", not a patch) and also please put > additional notices such as for backporting below the --- line. I read it as a warning to backporters that the patch, even though it may apply, was not tested and may even be wrong in 1.4. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 3/3] xen_machine_pv: do not create a dummy CPU in machine->init Date: Wed, 29 May 2013 14:29:51 +0200 Message-ID: <51A5F4BF.90504@redhat.com> References: <1369827271-20921-3-git-send-email-stefano.stabellini@eu.citrix.com> <51A5F06A.4040109@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <51A5F06A.4040109@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: aliguori@us.ibm.com, xen-devel@lists.xensource.com, Stefano Stabellini , qemu-devel@nongnu.org, qemu-stable@nongnu.org, anthony.perard@citrix.com, imammedo@redhat.com List-Id: xen-devel@lists.xenproject.org Il 29/05/2013 14:11, Andreas F=E4rber ha scritto: >> xen_machine_pv uses cpu_x86_init, therefore it has been broken. >> >> This patch fixes the problem by removing the dummy CPU creation >> altogether from xen_init_pv, relying on the fact that QEMU can now cop= e >> with a machine without an emulated CPU. >> >> This fix should be backported to QEMU 1.5. >> >> Signed-off-by: Stefano Stabellini >> CC: imammedo@redhat.com >> CC: qemu-stable@nongnu.org >=20 > Change looks okay, >=20 > Reviewed-by: Andreas F=E4rber >=20 > But for the future please avoid "this patch" in the commit message > (because later on it's a "commit", not a patch) and also please put > additional notices such as for backporting below the --- line. I read it as a warning to backporters that the patch, even though it may apply, was not tested and may even be wrong in 1.4. Paolo