All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: blauwirbel@gmail.com, peter.maydell@linaro.org,
	peter.crosthwaite@xilinx.com, qemu-devel@nongnu.org,
	kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 4/5] xilinx_devcfg: Zynq devcfg device model
Date: Wed, 29 May 2013 19:08:45 +0200	[thread overview]
Message-ID: <51A6361D.50706@redhat.com> (raw)
In-Reply-To: <20130529170459.GK23342@smtp.vpn>

Il 29/05/2013 19:04, Edgar E. Iglesias ha scritto:
>> > +    for (i = 0; i < R_MAX; ++i) {
>> > +        RegisterInfo *r = &s->regs_info[i];
>> > +
>> > +        *r = (RegisterInfo) {
>> > +            .data = &s->regs[i],
>> > +            .data_size = sizeof(uint32_t),
>> > +            .access = &xilinx_devcfg_regs_info[i],
>> > +            .debug = XILINX_DEVCFG_ERR_DEBUG,
>> > +            .prefix = prefix,
>> > +            .opaque = s,
>> > +        };
>> > +        memory_region_init_io(&r->mem, &devcfg_reg_ops, r, "devcfg-regs", 4);
> Hi Peter, Should we be putting r->access->name here instead of "devcfg-regs"?

Yes, that's why I preferred to wrap the memory_region_init_io into an
API that takes a RegisterInfo. :)

Paolo

  reply	other threads:[~2013-05-29 17:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-24  5:46 [Qemu-devel] [PATCH v3 0/5] Data Driven device registers & Zynq DEVCFG peter.crosthwaite
2013-05-24  5:46 ` [Qemu-devel] [PATCH v3 1/5] bitops: Add ONES macro peter.crosthwaite
2013-05-24  5:47 ` [Qemu-devel] [PATCH v3 2/5] register: Add Register API peter.crosthwaite
2013-05-29 17:52   ` Edgar E. Iglesias
2013-05-24  5:48 ` [Qemu-devel] [PATCH v3 3/5] register: Add Memory API glue peter.crosthwaite
2013-05-24  5:49 ` [Qemu-devel] [PATCH v3 4/5] xilinx_devcfg: Zynq devcfg device model peter.crosthwaite
2013-05-29  8:51   ` Paolo Bonzini
2013-05-29 13:54     ` Peter Crosthwaite
2013-05-29 14:03       ` Paolo Bonzini
2013-05-29 17:04   ` Edgar E. Iglesias
2013-05-29 17:08     ` Paolo Bonzini [this message]
2013-05-30  7:15       ` Peter Crosthwaite
2013-05-30 13:08         ` Paolo Bonzini
2013-05-29 17:57   ` Anthony Liguori
2013-05-29 18:52     ` Anthony Liguori
2013-05-30  1:43     ` Peter Crosthwaite
2013-05-30 19:41       ` Anthony Liguori
2013-05-31 23:34         ` Peter Crosthwaite
2013-05-24  5:49 ` [Qemu-devel] [PATCH v3 5/5] xilinx_zynq: added devcfg to machine model peter.crosthwaite

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A6361D.50706@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=kraxel@redhat.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.