From: Mark Hatle <mark.hatle@windriver.com>
To: Phil Blundell <pb@pbcl.net>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/21] Add directory information to the pkgdata files
Date: Wed, 29 May 2013 15:44:58 -0500 [thread overview]
Message-ID: <51A668CA.1070205@windriver.com> (raw)
In-Reply-To: <1369857580.6644.13.camel@pb-ThinkPad-R50e>
On 5/29/13 2:59 PM, Phil Blundell wrote:
> On Wed, 2013-05-29 at 11:30 -0500, Mark Hatle wrote:
>> It's up to the tooling that are using these files to check if the directory
>> exists, if it does not -- then using bitbake -c patch <recipe> will create it.
>> (even in the sstate-cache case.)
>
> I'm not sure whether checking that the directory exists is all that
> safe; in the shared-sstate scenario I think it's conceivable that the
> directory might exist but contain something else, or be unreadable due
> to permissions, or disappear underneath you while you're using it.
>
> And, of course, "bitbake -c patch ..." won't necessarily create the same
> ${S} that you got from pkgdata in that case, it will create it in your
> local TMPDIR.
On 5/29/13 12:36 PM, Khem Raj wrote:
> Hi Mark
>
> This won't work well when package is populated from sstate is there a way for it
> to work seamlessly across sstate it might be useful
I was looking at this again. I thought the pkgdata was reconstructed each time
in the current TMPDIR. I didn't realize it was just restored from the
sstate-cache. (We've got other patches in layers that trigger pkgdata-like
files to be generated as well.. and I must have gotten the two confused.)
So yes, I understand now that this won't work properly as the embedded path is
outside of the TMPDIR. The intention was that the path would change to match
the current build directories TMPDIR. And due to the magic of the sstate-cache
checksumming, running the do_patch should result in the same sources...
So -if- others thought this was useful, I'll fix the patch to change the S/B on
the sstate setup to the proper TMPDIR locations. But so far I'm not hearing
anyone who wants this -- so I'll just keep it local.
> Also, the subject line for this patch (and several others from the batch
> you just sent) is not in the right format. Please see the guidelines on
> the wiki.
I missed that, I'll correct the commits summary lines and resubmit them.
Drop 2/21
Fixup 9, 15, & 18
Did I miss any?
--Mark
> p.
>
>
next prev parent reply other threads:[~2013-05-29 20:44 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 15:09 [PATCH 0/21] Misc patch set Mark Hatle
2013-05-29 15:09 ` [PATCH 1/21] libxpm: inherit gettext Mark Hatle
2013-05-29 15:09 ` [PATCH 2/21] Add directory information to the pkgdata files Mark Hatle
2013-05-29 15:11 ` Paul Eggleton
2013-05-29 15:23 ` Mark Hatle
2013-05-29 15:59 ` Martin Jansa
2013-05-29 16:30 ` Mark Hatle
2013-05-29 17:36 ` Khem Raj
2013-05-29 19:59 ` Phil Blundell
2013-05-29 20:44 ` Mark Hatle [this message]
2013-05-30 8:29 ` Paul Eggleton
2013-05-30 8:33 ` Richard Purdie
2013-05-29 15:09 ` [PATCH 3/21] cmake.bbclass: modify construction of compiler flags Mark Hatle
2013-05-29 15:09 ` [PATCH 4/21] acpid: modify CFLAGS Mark Hatle
2013-05-29 15:09 ` [PATCH 5/21] libpam: Avoid wildcards in the SRC_URI Mark Hatle
2013-05-29 15:09 ` [PATCH 6/21] util-linux: Add ability to compile with nativesdk Mark Hatle
2013-05-29 15:09 ` [PATCH 7/21] dbus-glib: use BPN instead of PN Mark Hatle
2013-05-29 15:09 ` [PATCH 8/21] initscripts: let status return 0 when proc is running well Mark Hatle
2013-05-29 15:09 ` [PATCH 9/21] pull ldlinux.sys and isolinux.bin from correct places Mark Hatle
2013-05-29 15:09 ` [PATCH 10/21] ncurses, busybox, cml1.bbclass: Fix menuconfig display corruption Mark Hatle
2013-05-29 21:15 ` Richard Purdie
2013-05-29 15:09 ` [PATCH 11/21] guile: don't search for libreadline in host libdir Mark Hatle
2013-05-29 15:09 ` [PATCH 12/21] dpkg-native: Fix native perl path Mark Hatle
2013-05-29 15:09 ` [PATCH 13/21] qmake_base.bbclass:add linux-gnun32-oe-g++ to QMAKESPEC Mark Hatle
2013-05-29 15:09 ` [PATCH 14/21] portmap: /etc/init.d/portmap restart complains "command not found" Mark Hatle
2013-05-29 15:09 ` [PATCH 15/21] fix libnl two parentheses bugs in lib/cache_mngr.c file Mark Hatle
2013-05-29 15:09 ` [PATCH 16/21] bind: add ipv6 support Mark Hatle
2013-05-29 15:09 ` [PATCH 17/21] grep: fix for CVE-2012-5667 Mark Hatle
2013-05-29 21:21 ` Richard Purdie
2013-05-29 15:10 ` [PATCH 18/21] Fix problems expanding the IMAGE_INSTALL package groups Mark Hatle
2013-05-29 21:10 ` Richard Purdie
2013-05-29 21:28 ` Mark Hatle
2013-05-29 21:59 ` Richard Purdie
2013-05-30 10:46 ` Phil Blundell
2013-05-30 12:22 ` Mark Hatle
2013-05-30 20:10 ` Richard Purdie
2013-05-29 15:10 ` [PATCH 19/21] siteinfo.bbclass: Add mips64 common siteinfo Mark Hatle
2013-05-29 15:10 ` [PATCH 20/21] cracklib: Allow byte order patch to work on older Linux hosts Mark Hatle
2013-05-29 15:10 ` [PATCH 21/21] libarchive: Fix build dependencies Mark Hatle
2013-05-30 0:53 ` [PATCH 0/21] Misc patch set Saul Wold
2013-05-30 3:55 ` Mark Hatle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A668CA.1070205@windriver.com \
--to=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=pb@pbcl.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.