From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46040)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UiUm1-0002FT-1C
	for qemu-devel@nongnu.org; Fri, 31 May 2013 15:14:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UiUlx-0002cz-Ag
	for qemu-devel@nongnu.org; Fri, 31 May 2013 15:14:00 -0400
Received: from mail-vb0-x230.google.com ([2607:f8b0:400c:c02::230]:36225)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1UiUlx-0002cs-5k
	for qemu-devel@nongnu.org; Fri, 31 May 2013 15:13:57 -0400
Received: by mail-vb0-f48.google.com with SMTP id w8so1287276vbf.7
	for <qemu-devel@nongnu.org>; Fri, 31 May 2013 12:13:56 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <51A8F670.1060601@twiddle.net>
Date: Fri, 31 May 2013 12:13:52 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <51A8E339.5000500@huawei.com> <51A8E663.8020204@huawei.com>
In-Reply-To: <51A8E663.8020204@huawei.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/4] tcg/aarch64: implement sign/zero
	extend operations
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jani Kokkonen <Jani.Kokkonen@huawei.com>
Cc: Laurent Desnogues <laurent.desnogues@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Claudio Fontana <claudio.fontana@huawei.com>, qemu-devel@nongnu.org

On 05/31/2013 11:05 AM, Jani Kokkonen wrote:
> +static inline void tcg_out_uxt(TCGContext *s, int s_bits,
> +                               TCGReg rd, TCGReg rn)
> +{
> +    /* using ALIASes UXTB 0x53001c00, UXTH 0x53003c00
> +       of UBFM Wd, Wn, #0, #7|15 and mov */
> +    int bits = 8 * (1 << s_bits) - 1;
> +    tcg_out_ubfm(s, 0, rd, rn, 0, bits);
> +}

Err, ubfm never generates mov, does it?

Yes, you do that later,

> +    case INDEX_op_ext32u_i64:
> +        tcg_out_movr(s, 0, args[0], args[1]);
> +        break;

but the comment isn't actually correct in tcg_out_uxt, surely?


r~