All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gao feng <gaofeng@cn.fujitsu.com>
To: Arkadiusz Miskiewicz <a.miskiewicz@gmail.com>
Cc: Jason Wang <jasowang@redhat.com>,
	netdev@vger.kernel.org,
	Balakumaran Kannan <kumaran.4353@gmail.com>,
	Maruthi Thotad <Maruthi.Thotad@ap.sony.com>
Subject: Re: [PATCH] net: tun: release the reference of tun device in tun_recvmsg
Date: Mon, 03 Jun 2013 16:26:45 +0800	[thread overview]
Message-ID: <51AC5345.6020904@cn.fujitsu.com> (raw)
In-Reply-To: <201305290029.35303.a.miskiewicz@gmail.com>

On 05/29/2013 06:29 AM, Arkadiusz Miskiewicz wrote:
> On Friday 26 of April 2013, Jason Wang wrote:
>> On 04/26/2013 01:03 PM, Gao feng wrote:
>>> On 04/25/2013 11:04 PM, Arkadiusz Miskiewicz wrote:
>>>> On Thursday 25 of April 2013, Gao feng wrote:
>>>>> We forget to release the reference of tun device in tun_recvmsg.
>>>>> bug introduced in commit 54f968d6efdbf7dec36faa44fc11f01b0e4d1990
>>>>> (tuntap: move socket to tun_file)
>>>>
>>>> Hm, still hitting the problem even with the patch - dmesg:
>>> Ok, seams there are another problems we haven't discovered.
>>> it's excellent if you can find out which commit introduces this
>>> bug by git bisect.
>>>
>>> Thanks!
>>
>> Yes, bisect will be helpful. If you could not do it, please tell me the
>> steps to reproduce the issue and the tree you used. I just test with
>> net.git and net-next.git with a tap device created by tunctl, didn't
>> meet the issue.
> 
> Took a while. Suspected patch is below. I'm running fresh linus git
> (3.10.0-rc3-00046-g58f8bbd) with the patch reverted and couldn't
> reproduce problem anymore after several tries (will do more testing
> in meantime).

Thanks for your helpful work :)
I already send a patch to fix this problem.

> 
> My tap0 has ipv6 addresses (with link scope only). openvpn 2.3.1.

Indeed, not only tap/tun device, the other net devices can trigger
this problem too.


Thanks!

  parent reply	other threads:[~2013-06-03  8:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-25  6:22 3.9.0-rc8-00005-g824282c: [24988.276086] unregister_netdevice: waiting for tap0 to become free. Usage count = 1 Arkadiusz Miskiewicz
2013-04-25  7:59 ` [PATCH] net: tun: release the reference of tun device in tun_recvmsg Gao feng
2013-04-25  7:59   ` Jason Wang
2013-04-25 15:04   ` Arkadiusz Miskiewicz
2013-04-26  5:03     ` Gao feng
2013-04-26  5:08       ` Jason Wang
2013-05-28 22:29         ` Arkadiusz Miskiewicz
2013-06-03  8:16           ` [PATCH] ipv6: assign rt6_info to inet6_ifaddr in init_loopback Gao feng
2013-06-04 23:58             ` David Miller
2013-06-03  8:26           ` Gao feng [this message]
2013-06-05 15:20             ` [PATCH] net: tun: release the reference of tun device in tun_recvmsg Arkadiusz Miskiewicz
2013-06-05 15:36               ` Eric Dumazet
2013-04-29 15:07   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51AC5345.6020904@cn.fujitsu.com \
    --to=gaofeng@cn.fujitsu.com \
    --cc=Maruthi.Thotad@ap.sony.com \
    --cc=a.miskiewicz@gmail.com \
    --cc=jasowang@redhat.com \
    --cc=kumaran.4353@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.