From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>, Ben Guthro <ben@guthro.net>
Cc: xen-devel <xen-devel@lists.xen.org>
Subject: Re: S3 crash with VTD Queue Invalidation enabled
Date: Tue, 04 Jun 2013 09:54:44 +0100 [thread overview]
Message-ID: <51ADC77402000078000DAF95@nat28.tlf.novell.com> (raw)
In-Reply-To: <51ACECEB.9030904@citrix.com>
>>> On 03.06.13 at 21:22, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
> On 03/06/13 19:29, Ben Guthro wrote:
>> (XEN) Xen call trace:
>> (XEN) [<ffff82c480149091>] invalidate_sync+0x258/0x291
>> (XEN) [<ffff82c48014919d>] flush_iotlb_qi+0xd3/0xef
>> (XEN) [<ffff82c480145a60>] iommu_flush_all+0xb5/0xde
>> (XEN) [<ffff82c480145b08>] vtd_suspend+0x23/0xf1
>> (XEN) [<ffff82c480141e12>] iommu_suspend+0x3c/0x3e
>> (XEN) [<ffff82c48019f315>] enter_state_helper+0x1a0/0x3cb
>> (XEN) [<ffff82c480105ed4>] continue_hypercall_tasklet_handler+0x51/0xbf
>> (XEN) [<ffff82c480127a1e>] do_tasklet_work+0x8d/0xc7
>> (XEN) [<ffff82c480127d89>] do_tasklet+0x6b/0x9b
>> (XEN) [<ffff82c48015a42f>] idle_loop+0x67/0x6f
>
> This was likely broken by XSA-36
>
> My fix for the crash path is:
> http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=53fd1d8458de01169dfb
> 56feb315f02c2b521a86
>
> You want to inspect the use of iommu_enabled and iommu_intremap.
According to the comment in vtd_suspend(),
iommu_disable_x2apic_IR() is supposed to run after
iommu_suspend() (and indeed lapic_suspend() gets called
immediately after iommu_suspend() by device_power_down()),
and hence that shouldn't be the reason here. But, Ben, to be
sure, dumping the state of the various IOMMU related enabling
variables would be a good idea.
Is this perhaps having some similarity with
http://lists.xen.org/archives/html/xen-devel/2013-04/msg00343.html?
We're clearly running single-CPU only here and there...
Jan
next prev parent reply other threads:[~2013-06-04 8:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 18:29 S3 crash with VTD Queue Invalidation enabled Ben Guthro
2013-06-03 19:22 ` Andrew Cooper
2013-06-04 8:54 ` Jan Beulich [this message]
2013-06-04 12:25 ` Ben Guthro
2013-06-04 14:01 ` Jan Beulich
2013-06-04 19:20 ` Ben Guthro
2013-06-04 19:49 ` Ben Guthro
2013-06-04 21:09 ` Ben Guthro
2013-06-05 8:24 ` Jan Beulich
2013-06-05 13:54 ` Ben Guthro
2013-06-05 15:14 ` Jan Beulich
2013-06-05 15:25 ` Ben Guthro
2013-06-05 15:38 ` Jan Beulich
2013-06-05 20:27 ` Ben Guthro
2013-06-05 23:53 ` Ben Guthro
2013-06-06 6:58 ` Jan Beulich
2013-06-06 15:06 ` Zhang, Xiantao
2013-06-06 15:07 ` Ben Guthro
2013-06-06 15:13 ` Zhang, Xiantao
2013-06-06 15:17 ` Ben Guthro
2013-06-07 1:33 ` Zhang, Xiantao
2013-06-07 15:52 ` Ben Guthro
2013-06-14 8:38 ` Jan Beulich
2013-06-14 17:01 ` Ben Guthro
2013-06-14 18:27 ` Ben Guthro
2013-06-17 7:23 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ADC77402000078000DAF95@nat28.tlf.novell.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ben@guthro.net \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.