From: "Andreas Färber" <afaerber@suse.de>
To: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Cc: andre.przywara@amd.com, aliguori@us.ibm.com, pbonzini@redhat.com,
qemu-devel@nongnu.org, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] Add Linux libnuma detection
Date: Wed, 05 Jun 2013 12:02:58 +0200 [thread overview]
Message-ID: <51AF0CD2.80602@suse.de> (raw)
In-Reply-To: <1370404705-4620-1-git-send-email-gaowanlong@cn.fujitsu.com>
Am 05.06.2013 05:58, schrieb Wanlong Gao:
> Add detection of libnuma (mostly contained in the numactl package)
> to the configure script. Currently this is Linux only, but can be
> extended later should the need for other interfaces come up.
> Can be enabled or disabled on the command line, default is use if
> available.
>
> Original-signed-off-by: Andre Przywara <andre.przywara@amd.com>
This should be just Signed-off-by, the difference between From and Sob
already indicates you changed his code.
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> ---
> configure | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/configure b/configure
> index 1654413..d897f98 100755
> --- a/configure
> +++ b/configure
> @@ -242,6 +242,7 @@ gtk=""
> gtkabi="2.0"
> tpm="no"
> libssh2=""
> +numa="yes"
This should be "" by default - it is not needed by linux-user and when
--enable-numa is used we should error out if it's not there.
>
> # parse CC options first
> for opt do
> @@ -937,6 +938,10 @@ for opt do
> ;;
> --enable-libssh2) libssh2="yes"
> ;;
> + --disable-numa) numa="no"
> + ;;
> + --enable-numa) numa="yes"
> + ;;
> *) echo "ERROR: unknown option $opt"; show_help="yes"
> ;;
> esac
> @@ -1151,6 +1156,8 @@ echo " --gcov=GCOV use specified gcov [$gcov_tool]"
> echo " --enable-tpm enable TPM support"
> echo " --disable-libssh2 disable ssh block device support"
> echo " --enable-libssh2 enable ssh block device support"
> +echo " --disable-numa disable host Linux NUMA support"
> +echo " --enable-numa enable host Linux NUMA support"
> echo ""
> echo "NOTE: The object files are built at the place where configure is launched"
> exit 1
> @@ -2382,6 +2389,27 @@ EOF
> fi
>
> ##########################################
> +# libnuma probe
> +
> +if test "$numa" = "yes" ; then
Requires to check for != "no" here.
> + numa=no
> + cat > $TMPC << EOF
> +#include <numa.h>
> +int main(void) { return numa_available(); }
> +EOF
> +
> + if compile_prog "" "-lnuma" ; then
> + numa=yes
> + libs_softmmu="-lnuma $libs_softmmu"
> + else
> + if test "$numa" = "yes" ; then
> + feature_not_found "linux NUMA (install numactl?)"
> + fi
> + numa=no
> + fi
> +fi
> +
> +##########################################
> # linux-aio probe
>
> if test "$linux_aio" != "no" ; then
> @@ -3550,6 +3578,7 @@ echo "TPM support $tpm"
> echo "libssh2 support $libssh2"
> echo "TPM passthrough $tpm_passthrough"
> echo "QOM debugging $qom_cast_debug"
> +echo "NUMA host support $numa"
>
> if test "$sdl_too_old" = "yes"; then
> echo "-> Your SDL version is too old - please upgrade to have SDL support"
> @@ -3584,6 +3613,9 @@ echo "extra_cflags=$EXTRA_CFLAGS" >> $config_host_mak
> echo "extra_ldflags=$EXTRA_LDFLAGS" >> $config_host_mak
> echo "qemu_localedir=$qemu_localedir" >> $config_host_mak
> echo "libs_softmmu=$libs_softmmu" >> $config_host_mak
> +if test "$numa" = "yes"; then
> + echo "CONFIG_NUMA=y" >> $config_host_mak
> +fi
>
> echo "ARCH=$ARCH" >> $config_host_mak
>
>
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2013-06-05 10:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 3:58 [Qemu-devel] [PATCH 1/2] Add Linux libnuma detection Wanlong Gao
2013-06-05 3:58 ` [Qemu-devel] [PATCH 2/2] Add monitor command mem-nodes Wanlong Gao
2013-06-05 12:39 ` Eric Blake
2013-06-05 12:57 ` Anthony Liguori
2013-06-05 15:54 ` Eduardo Habkost
2013-06-06 9:30 ` Wanlong Gao
2013-06-06 16:15 ` Eduardo Habkost
2013-06-14 1:04 ` Anthony Liguori
2013-06-14 13:56 ` Eduardo Habkost
2013-06-05 13:46 ` Eduardo Habkost
2013-06-11 7:22 ` Wanlong Gao
2013-06-11 13:40 ` Eduardo Habkost
2013-06-13 1:40 ` Wanlong Gao
2013-06-13 12:50 ` Eduardo Habkost
2013-06-13 22:32 ` Paolo Bonzini
2013-06-14 1:05 ` Anthony Liguori
2013-06-14 1:16 ` Wanlong Gao
2013-06-15 17:23 ` Paolo Bonzini
2013-06-05 10:02 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51AF0CD2.80602@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=andre.przywara@amd.com \
--cc=ehabkost@redhat.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.