From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756430Ab3FFIjQ (ORCPT ); Thu, 6 Jun 2013 04:39:16 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:48835 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751061Ab3FFIjN (ORCPT ); Thu, 6 Jun 2013 04:39:13 -0400 Message-ID: <51B04AA9.4070803@monstr.eu> Date: Thu, 06 Jun 2013 10:39:05 +0200 From: Michal Simek Reply-To: monstr@monstr.eu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130330 Thunderbird/17.0.5 MIME-Version: 1.0 To: Jean-Christophe PLAGNIOL-VILLARD CC: Michal Simek , Michal Simek , Grant Likely , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Rob Herring Subject: Re: [PATCH] of: Export of_irq_count for using in modules References: <6aa29b1d109a46278a7f37b598defe07d6edfe60.1369921774.git.michal.simek@xilinx.com> <20130530201714.GE19834@game.jcrosoft.org> <51A85BEE.4000009@monstr.eu> <20130531110045.GF19834@game.jcrosoft.org> <51A8AC4B.906@monstr.eu> <20130531151601.GG19834@game.jcrosoft.org> <51A8D3A3.5030200@monstr.eu> <20130606082941.GH19834@game.jcrosoft.org> In-Reply-To: <20130606082941.GH19834@game.jcrosoft.org> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2PAERDEGBTLMWKQQQMFFM" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2PAERDEGBTLMWKQQQMFFM Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 06/06/2013 10:29 AM, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 18:45 Fri 31 May , Michal Simek wrote: >> On 05/31/2013 05:16 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: >>> On 15:57 Fri 31 May , Michal Simek wrote: >>>> On 05/31/2013 01:00 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: >>>>> On 10:14 Fri 31 May , Michal Simek wrote: >>>>>> Hi Jean-Christophe, >>>>>> >>>>>> On 05/30/2013 10:17 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: >>>>>>> On 15:49 Thu 30 May , Michal Simek wrote: >>>>>>>> Export of_irq_count for modules. >>>>>>> >>>>>>> can you explain why do you need to call of_irq_count >>>>>> >>>>>> I need to count number of irq written in the DTS node. >>>>>> It is not fixed size that's why I need to proper way how to >>>>>> find it out. >>>>>> >>>>>> I am using this loop. >>>>>> count =3D of_irq_count(pdev->dev.of_node); >>>>>> /* Alloc IRQ based on DTS to be sure that no other driver will us= e it */ >>>>>> while (count--) { >>>>>> tmp->irq =3D irq_of_parse_and_map(pdev->dev.of_node, count); >>>>>> dev_info(&pdev->dev, "%d: Alloc irq: %d\n", count, tmp->irq); >>>>>> ret =3D request_irq(tmp->irq, zynq_remoteproc_interrupt, 0, >>>>>> dev_name(&pdev->dev), &pdev->dev); >>>>>> if (ret) { >>>>>> ... >>>>>> } >>>>>> } >>>>>> >>>>>> But of course if you think that this is incorrect to export it >>>>>> I can use what it is in of_irq_count body >>>>>> 368 int of_irq_count(struct device_node *dev) >>>>>> 369 { >>>>>> 370 int nr =3D 0; >>>>>> 371 >>>>>> 372 while (of_irq_to_resource(dev, nr, NULL)) >>>>>> 373 nr++; >>>>>> 374 >>>>>> 375 return nr; >>>>>> 376 } >>>>>> >>>>>> Because of_irq_to_resource is exported for modules. >>>>>> Or is there any better way how to loop over all interrupts in DT n= ode? >>>>> >>>>> can just explain me why you need to call irq_of_parse_and_map in yo= ur driver? >>>>> >>>>> as the irq will be provided in the resources normally >>>> >>>> It is quite a long time I have written this driver on v3.1 or 3.3. >>>> But is this better? >>>> >>>> struct resource *res; >>>> int i =3D 0; >>>> do { >>>> res =3D platform_get_resource(pdev, IORESOURCE_IRQ, i++); >>>> if (res) >>>> do something >>>> } while(res); >>>> >>>> Also what about of_irq_to_resource()? Is it deprecated and all drive= rs >>>> shouldn't use it? >>>> >>>> I have no problem to rewrite the driver to use platform_get_resource= =2E >>> yeah it's better but be aware there is a but in DT that I'm working o= n to fix >>> if you use irq that are registered by a pdev this will not work >>> >>> I hope to fix it for 3.11 >>> and already send an RFC that fix it >> >> ok. good to know. Btw: Let's return to my origin point why not to >> export of_irq_count for modules? >> Or opposite question if platform_get_resource is correct way >> why to export of_irq_to_resource for modules? >=20 > for old ppc drivers that are not converted yet to pdev >=20 > if you can do so just use pdev resource I should have fix the pb or irq= _domain > hopefully for 3.11 ok. It means it is currently deprecated. I just wanted to be sure that I understand it correctly. I have changed my drivers not to use this function and using resources as= we discussed. btw: I have sent one email to device-tree ML about describing missing connection between cpu and the first interrupt controller. Can you please look at it and comment it? https://lists.ozlabs.org/pipermail/devicetree-discuss/2013-May/033955.htm= l Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform ------enig2PAERDEGBTLMWKQQQMFFM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlGwSqkACgkQykllyylKDCGF6wCcD4Urwiez7vV4dZ5+sDFBv3Ik +yYAoIFboOUjlMFHDTbJTtFcEZsq6gCm =RA2p -----END PGP SIGNATURE----- ------enig2PAERDEGBTLMWKQQQMFFM--