From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: Re: [PATCH] xen: fix initialization of wallclock time for PVHVM on migration Date: Tue, 11 Jun 2013 15:38:07 +0200 Message-ID: <51B7283F.4020602@citrix.com> References: <1370947577-5965-1-git-send-email-roger.pau@citrix.com> <51B72D3602000078000DD0FD@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51B72D3602000078000DD0FD@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: George Dunlap , Keir Fraser , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 11/06/13 13:59, Jan Beulich wrote: >>>> On 11.06.13 at 12:46, Roger Pau Monne wrote: >> The initial values of the wallclock time in the shared info page are >> set for PVHVM guests when the hypercall page is initialized, since the >> hypercall page is not reinitialized on resume, the hypervisor >> wallclock time is not properly set on resume. >> >> Fix it by forcing an update of the wallclock values when the shared >> info page is mapped. > > NACK - this is a guest side bug. After migration, a guest _has_ to > re-init the hypercall page, as it may have got migrated between > a VMX and an SVM machine, and the hypercall instructions are > different between them. I've re-inited the hypercall page on resume, but the hypervisor wallclock is still 0. The call to update_domain_wallclock_time in hvm_latch_shinfo_size is gated, and doesn't get called on the resume path. Would it be OK to call update_domain_wallclock_time unconditionally on hvm_hypercall_page_initialise?