From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: "Lee Jones" <lee.jones@linaro.org>,
"Benoît Cousson" <b-cousson@ti.com>,
"Tony Lindgren" <tony@atomide.com>,
"Jonathan Cameron" <jic23@cam.ac.uk>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Felipe Balbi" <balbi@ti.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-iio@vger.kernel.org, linux-input@vger.kernel.org, "Patil,
Rachna" <rachna@ti.com>
Subject: Re: [PATCH 04/22] input/ti_am33x_tsc: Order of TSC wires, made configurable
Date: Tue, 11 Jun 2013 16:35:56 +0200 [thread overview]
Message-ID: <51B735CC.9080909@linutronix.de> (raw)
In-Reply-To: <20130611142324.GD29135@zurbaran>
On 06/11/2013 04:23 PM, Samuel Ortiz wrote:
> Hi Sebastian,
Hi Samuel,
> On Tue, Jun 11, 2013 at 01:30:50PM +0200, Sebastian Andrzej Siewior wrote:
>> diff --git a/include/linux/mfd/ti_am335x_tscadc.h b/include/linux/mfd/ti_am335x_tscadc.h
>> index eeead15..2d78af8 100644
>> --- a/include/linux/mfd/ti_am335x_tscadc.h
>> +++ b/include/linux/mfd/ti_am335x_tscadc.h
>> @@ -116,6 +113,13 @@
>> #define CNTRLREG_8WIRE CNTRLREG_AFE_CTRL(3)
>> #define CNTRLREG_TSCENB BIT(7)
>>
>> +#define XPP STEPCONFIG_XPP
>> +#define XNP STEPCONFIG_XNP
>> +#define XNN STEPCONFIG_XNN
>> +#define YPP STEPCONFIG_YPP
>> +#define YPN STEPCONFIG_YPN
>> +#define YNN STEPCONFIG_YNN
> What is that for ? Isn't STEPCONFIG_XPP explicit enough ?
Yeah :P It was added by the original author of the patch, I have no
problem getting rid of it.
>
> Cheers,
> Samuel.
Sebastian
next prev parent reply other threads:[~2013-06-11 14:36 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 11:30 am335x: TSC & ADC reworking including DT pieces, take 4 Sebastian Andrzej Siewior
2013-06-11 11:30 ` Sebastian Andrzej Siewior
2013-06-11 11:30 ` [PATCH 01/22] mfd/ti_am335x_tscadc: remove regmap Sebastian Andrzej Siewior
2013-06-11 14:23 ` Samuel Ortiz
2013-06-11 14:34 ` Sebastian Andrzej Siewior
2013-06-11 14:34 ` Sebastian Andrzej Siewior
2013-06-14 13:53 ` Mark Brown
2013-06-14 13:53 ` Mark Brown
2013-06-17 11:41 ` Sebastian Andrzej Siewior
2013-06-17 11:41 ` Sebastian Andrzej Siewior
2013-06-17 16:03 ` Mark Brown
2013-06-17 16:03 ` Mark Brown
2013-07-04 9:02 ` Sebastian Andrzej Siewior
2013-07-04 9:02 ` Sebastian Andrzej Siewior
2013-07-04 10:45 ` Mark Brown
2013-07-04 11:15 ` Sebastian Andrzej Siewior
2013-07-04 11:15 ` Sebastian Andrzej Siewior
2013-06-11 11:30 ` [PATCH 02/22] mfd & input & iio/ti_am335x_adc: use one structure for ti_tscadc_dev Sebastian Andrzej Siewior
2013-06-11 11:30 ` [PATCH 03/22] input/ti_am33x_tsc: Step enable bits made configurable Sebastian Andrzej Siewior
2013-06-11 11:30 ` [PATCH 04/22] input/ti_am33x_tsc: Order of TSC wires, " Sebastian Andrzej Siewior
2013-06-11 14:23 ` Samuel Ortiz
2013-06-11 14:23 ` Samuel Ortiz
2013-06-11 14:35 ` Sebastian Andrzej Siewior [this message]
2013-07-04 11:14 ` Sekhar Nori
2013-07-04 11:14 ` Sekhar Nori
2013-07-04 11:33 ` Sebastian Andrzej Siewior
2013-07-04 11:33 ` Sebastian Andrzej Siewior
2013-07-04 13:39 ` Sekhar Nori
2013-07-04 13:39 ` Sekhar Nori
2013-07-04 13:50 ` Sebastian Andrzej Siewior
2013-07-04 14:27 ` Sekhar Nori
2013-06-11 11:30 ` [PATCH 05/22] input/ti_am33x_tsc: remove unwanted fifo flush Sebastian Andrzej Siewior
2013-06-11 11:30 ` [PATCH 06/22] input/ti_am33x_tsc: Add DT support Sebastian Andrzej Siewior
2013-06-11 11:30 ` Sebastian Andrzej Siewior
2013-06-11 11:30 ` [PATCH 07/22] input/ti_am33x_tsc: remove platform_data support Sebastian Andrzej Siewior
2013-06-11 11:30 ` [PATCH 08/22] iio/ti_am335x_adc: Add DT support Sebastian Andrzej Siewior
2013-06-11 11:30 ` [PATCH 09/22] iio/ti_am335x_adc: remove platform_data support Sebastian Andrzej Siewior
2013-06-11 11:30 ` [PATCH 10/22] mfd/ti_am335x_tscadc: Add DT support Sebastian Andrzej Siewior
2013-06-11 14:23 ` Samuel Ortiz
2013-06-11 14:42 ` Sebastian Andrzej Siewior
2013-06-11 14:42 ` Sebastian Andrzej Siewior
2013-06-11 15:05 ` Samuel Ortiz
2013-06-11 15:41 ` Sebastian Andrzej Siewior
2013-06-11 15:41 ` Sebastian Andrzej Siewior
2013-06-11 18:42 ` Lee Jones
2013-06-11 18:42 ` Lee Jones
2013-06-11 17:10 ` Lee Jones
2013-06-11 17:10 ` Lee Jones
2013-06-11 11:30 ` [PATCH 11/22] mfd/ti_am335x_tscadc: remove platform_data support Sebastian Andrzej Siewior
2013-06-11 11:30 ` [PATCH 12/22] iio/ti_tscadc: provide datasheet_name and scan_type Sebastian Andrzej Siewior
2013-06-11 11:30 ` [PATCH 13/22] mfd/ti_tscadc: deal with partial activation Sebastian Andrzej Siewior
2013-06-11 11:31 ` [PATCH 14/22] arm/am33xx: add TSC/ADC mfd device support Sebastian Andrzej Siewior
2013-07-04 13:49 ` Sekhar Nori
2013-07-04 13:49 ` Sekhar Nori
2013-07-04 13:51 ` Sebastian Andrzej Siewior
2013-07-04 13:51 ` Sebastian Andrzej Siewior
2013-06-11 11:31 ` [PATCH 15/22] input & mfd: ti_am335x_tsc remove remaining platform data pieces Sebastian Andrzej Siewior
2013-06-11 11:31 ` [PATCH 16/22] mfd & input/ti_am335x_tsc: rename device from tsc to TI-am335x-tsc Sebastian Andrzej Siewior
2013-06-11 11:31 ` [PATCH 17/22] mfd & iio/ti_am335x_adc: rename device from tiadc to TI-am335x-adc Sebastian Andrzej Siewior
2013-06-11 11:31 ` Sebastian Andrzej Siewior
2013-06-11 11:31 ` [PATCH 18/22] input/ti_am335x_adc: use only FIFO0 and clean up a little Sebastian Andrzej Siewior
2013-06-11 11:31 ` [PATCH 19/22] input/ti_am335x_tsc: ACK the HW_PEN irq in ISR Sebastian Andrzej Siewior
2013-06-11 11:31 ` [PATCH 20/22] input/ti_am335x_tsc: return IRQ_NONE if there was no IRQ for us Sebastian Andrzej Siewior
2013-06-11 11:31 ` [PATCH 21/22] iio/ti_am335x_adc: Allow to specify input line Sebastian Andrzej Siewior
2013-06-11 11:31 ` [PATCH 22/22] iio/ti_am335x_adc: check if we found the value Sebastian Andrzej Siewior
2013-06-11 12:05 ` am335x: TSC & ADC reworking including DT pieces, take 4 Lee Jones
2013-06-11 12:05 ` Lee Jones
2013-06-11 13:53 ` Lars-Peter Clausen
2013-06-11 13:53 ` Lars-Peter Clausen
2013-06-11 14:23 ` Samuel Ortiz
2013-06-11 15:29 ` Sebastian Andrzej Siewior
2013-06-11 15:29 ` Sebastian Andrzej Siewior
2013-06-11 16:10 ` Samuel Ortiz
2013-06-11 16:10 ` Samuel Ortiz
2013-06-11 16:18 ` Sebastian Andrzej Siewior
2013-06-11 16:18 ` Sebastian Andrzej Siewior
2013-06-14 13:57 ` Mark Brown
2013-06-14 13:57 ` Mark Brown
2013-06-11 16:04 ` Dmitry Torokhov
2013-06-11 16:04 ` Dmitry Torokhov
2013-06-11 16:15 ` Samuel Ortiz
2013-06-11 16:15 ` Samuel Ortiz
2013-06-11 16:27 ` Jonathan Cameron
2013-06-11 16:27 ` Jonathan Cameron
2013-06-11 17:01 ` Lars-Peter Clausen
2013-06-11 17:01 ` Lars-Peter Clausen
2013-06-11 17:55 ` Samuel Ortiz
2013-06-11 17:55 ` Samuel Ortiz
2013-06-12 13:29 ` Sebastian Andrzej Siewior
2013-06-12 13:50 ` Samuel Ortiz
2013-06-12 13:50 ` Samuel Ortiz
2013-06-12 14:02 ` Sebastian Andrzej Siewior
2013-06-12 14:02 ` Sebastian Andrzej Siewior
2013-06-12 14:41 ` Samuel Ortiz
2013-06-12 15:00 ` Sebastian Andrzej Siewior
2013-06-11 18:02 ` Jonathan Cameron
2013-06-11 18:02 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2013-06-05 16:24 AM335x tsc & adc, dt + cleanup take 3 Sebastian Andrzej Siewior
[not found] ` <1370449495-29981-1-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2013-06-05 16:24 ` [PATCH 04/22] input/ti_am33x_tsc: Order of TSC wires, made configurable Sebastian Andrzej Siewior
2013-06-05 16:24 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B735CC.9080909@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jic23@cam.ac.uk \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rachna@ti.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.