From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754567Ab3FKOmj (ORCPT ); Tue, 11 Jun 2013 10:42:39 -0400 Received: from www.linutronix.de ([62.245.132.108]:34774 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752057Ab3FKOmh (ORCPT ); Tue, 11 Jun 2013 10:42:37 -0400 Message-ID: <51B73756.5010004@linutronix.de> Date: Tue, 11 Jun 2013 16:42:30 +0200 From: Sebastian Andrzej Siewior User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12 MIME-Version: 1.0 To: Samuel Ortiz CC: Lee Jones , =?windows-1252?Q?Beno=EEt_Cousson?= , Tony Lindgren , Jonathan Cameron , Dmitry Torokhov , Felipe Balbi , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, "Patil, Rachna" , Pantelis Antoniou Subject: Re: [PATCH 10/22] mfd/ti_am335x_tscadc: Add DT support References: <1370950268-7224-1-git-send-email-bigeasy@linutronix.de> <1370950268-7224-11-git-send-email-bigeasy@linutronix.de> <20130611142347.GF29135@zurbaran> In-Reply-To: <20130611142347.GF29135@zurbaran> X-Enigmail-Version: 1.4.1 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/11/2013 04:23 PM, Samuel Ortiz wrote: > Hi Sebastian, Hi Samuel, > On Tue, Jun 11, 2013 at 01:30:56PM +0200, Sebastian Andrzej Siewior wrote: >> From: "Patil, Rachna" >> >> Make changes to add DT support in the MFD core driver. > Which changes ? So rewrite the commit log… >> [ panto@antoniou-consulting.com : use of_get_child_by_name >> instead of of_find_node_by_name ] > I have no idea where that is coming from. Please remove this kind of > stuff and build a proper commit log instead. > > >> Signed-off-by: Pantelis Antoniou >> Signed-off-by: Patil, Rachna >> Signed-off-by: Felipe Balbi >> [bigeasy: module alias, rename to ti,am3359-tscadc as it was tested on >> AM3359] > I honestly can't tell if this is a change from the last version of your > patchset or a description of this patch changes in general. > This is cluttering your commit logs, please remove this as well. I took the original patch. Every change I made to it because people asked to merge changes into the patch where the problem occurred I added it here before my sign-off. In the end I would like not to post a patch with "From: != me" and don't make change which the original author did not do. Also dropping their authorship isn't nice. What could we agree on? > Cheers, > Samuel. Sebastian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Andrzej Siewior Subject: Re: [PATCH 10/22] mfd/ti_am335x_tscadc: Add DT support Date: Tue, 11 Jun 2013 16:42:30 +0200 Message-ID: <51B73756.5010004@linutronix.de> References: <1370950268-7224-1-git-send-email-bigeasy@linutronix.de> <1370950268-7224-11-git-send-email-bigeasy@linutronix.de> <20130611142347.GF29135@zurbaran> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from www.linutronix.de ([62.245.132.108]:34774 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752057Ab3FKOmh (ORCPT ); Tue, 11 Jun 2013 10:42:37 -0400 In-Reply-To: <20130611142347.GF29135@zurbaran> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Samuel Ortiz Cc: Lee Jones , =?windows-1252?Q?Beno=EEt_Cousson?= , Tony Lindgren , Jonathan Cameron , Dmitry Torokhov , Felipe Balbi , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, "Patil, Rachna" , Pantelis Antoniou On 06/11/2013 04:23 PM, Samuel Ortiz wrote: > Hi Sebastian, Hi Samuel, > On Tue, Jun 11, 2013 at 01:30:56PM +0200, Sebastian Andrzej Siewior w= rote: >> From: "Patil, Rachna" >> >> Make changes to add DT support in the MFD core driver. > Which changes ? So rewrite the commit log=85 >> [ panto@antoniou-consulting.com : use of_get_child_by_name >> instead of of_find_node_by_name ] > I have no idea where that is coming from. Please remove this kind of > stuff and build a proper commit log instead. >=20 >=20 >> Signed-off-by: Pantelis Antoniou >> Signed-off-by: Patil, Rachna >> Signed-off-by: Felipe Balbi >> [bigeasy: module alias, rename to ti,am3359-tscadc as it was tested = on >> AM3359] > I honestly can't tell if this is a change from the last version of yo= ur > patchset or a description of this patch changes in general. > This is cluttering your commit logs, please remove this as well. I took the original patch. Every change I made to it because people asked to merge changes into the patch where the problem occurred I added it here before my sign-off. In the end I would like not to post a patch with "From: !=3D me" and don't make change which the original author did not do. Also dropping their authorship isn't nice. What could we agree on? > Cheers, > Samuel. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html