From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754719Ab3FLKs7 (ORCPT ); Wed, 12 Jun 2013 06:48:59 -0400 Received: from eu1sys200aog106.obsmtp.com ([207.126.144.121]:49385 "EHLO eu1sys200aog106.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878Ab3FLKs5 (ORCPT ); Wed, 12 Jun 2013 06:48:57 -0400 Message-ID: <51B85151.2060409@st.com> Date: Wed, 12 Jun 2013 11:45:37 +0100 From: Srinivas KANDAGATLA Reply-To: srinivas.kandagatla@st.com Organization: STMicroelectronics User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Linus Walleij Cc: Mauro Carvalho Chehab , "linux-doc@vger.kernel.org" , Will Deacon , Mike Turquette , Samuel Ortiz , Stephen Gallimore , "linux-serial@vger.kernel.org" , Grant Likely , "devicetree-discuss@lists.ozlabs.org" , Rob Herring , Stuart Menefy , Mark Brown , John Stultz , Russell King - ARM Linux , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Andrew Morton , "David S. Miller" Subject: Re: [PATCH v2 02/11] clocksource:global_timer: Add ARM global timer support. References: <1370855828-5318-1-git-send-email-srinivas.kandagatla@st.com> <1370856087-6452-1-git-send-email-srinivas.kandagatla@st.com> <51B5D7A6.1020101@st.com> <51B72E9A.6070006@st.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/06/13 21:13, Linus Walleij wrote: > On Tue, Jun 11, 2013 at 4:05 PM, Srinivas KANDAGATLA > wrote: > >> Doing this is not adding any value to the driver, because >> 1. Currently the driver only support DT boot paths, in my previous RFC >> patches, Arnd suggested to get rid of the header as all platforms are DT >> now. > > In that case why do you have the separate global_timer_init() > at all? Just move that code into global_timer_of_register() and > also remove the #ifdef around CONFIG_OF and make the driver > depend on CONFIG_OF in Kconfig. > > After this you realize that all that business with > clk_register_clkdev() / clk_get_sys() is just pure surplus > baggade, you just use of_clk_get() and that's it. It makes sense to move all the code into global_timer_of_register(). This will also get rid of un-used code. I will do this in the next spin. Thanks, srini > > Yours, > Linus Walleij > _______________________________________________ > devicetree-discuss mailing list > devicetree-discuss@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/devicetree-discuss > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas KANDAGATLA Subject: Re: [PATCH v2 02/11] clocksource:global_timer: Add ARM global timer support. Date: Wed, 12 Jun 2013 11:45:37 +0100 Message-ID: <51B85151.2060409@st.com> References: <1370855828-5318-1-git-send-email-srinivas.kandagatla@st.com> <1370856087-6452-1-git-send-email-srinivas.kandagatla@st.com> <51B5D7A6.1020101@st.com> <51B72E9A.6070006@st.com> Reply-To: srinivas.kandagatla@st.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-doc-owner@vger.kernel.org To: Linus Walleij Cc: Mauro Carvalho Chehab , "linux-doc@vger.kernel.org" , Will Deacon , Mike Turquette , Samuel Ortiz , Stephen Gallimore , "linux-serial@vger.kernel.org" , Grant Likely , "devicetree-discuss@lists.ozlabs.org" , Rob Herring , Stuart Menefy , Mark Brown , John Stultz , Russell King - ARM Linux , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Andrew List-Id: devicetree@vger.kernel.org On 11/06/13 21:13, Linus Walleij wrote: > On Tue, Jun 11, 2013 at 4:05 PM, Srinivas KANDAGATLA > wrote: > >> Doing this is not adding any value to the driver, because >> 1. Currently the driver only support DT boot paths, in my previous RFC >> patches, Arnd suggested to get rid of the header as all platforms are DT >> now. > > In that case why do you have the separate global_timer_init() > at all? Just move that code into global_timer_of_register() and > also remove the #ifdef around CONFIG_OF and make the driver > depend on CONFIG_OF in Kconfig. > > After this you realize that all that business with > clk_register_clkdev() / clk_get_sys() is just pure surplus > baggade, you just use of_clk_get() and that's it. It makes sense to move all the code into global_timer_of_register(). This will also get rid of un-used code. I will do this in the next spin. Thanks, srini > > Yours, > Linus Walleij > _______________________________________________ > devicetree-discuss mailing list > devicetree-discuss@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/devicetree-discuss > From mboxrd@z Thu Jan 1 00:00:00 1970 From: srinivas.kandagatla@st.com (Srinivas KANDAGATLA) Date: Wed, 12 Jun 2013 11:45:37 +0100 Subject: [PATCH v2 02/11] clocksource:global_timer: Add ARM global timer support. In-Reply-To: References: <1370855828-5318-1-git-send-email-srinivas.kandagatla@st.com> <1370856087-6452-1-git-send-email-srinivas.kandagatla@st.com> <51B5D7A6.1020101@st.com> <51B72E9A.6070006@st.com> Message-ID: <51B85151.2060409@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/06/13 21:13, Linus Walleij wrote: > On Tue, Jun 11, 2013 at 4:05 PM, Srinivas KANDAGATLA > wrote: > >> Doing this is not adding any value to the driver, because >> 1. Currently the driver only support DT boot paths, in my previous RFC >> patches, Arnd suggested to get rid of the header as all platforms are DT >> now. > > In that case why do you have the separate global_timer_init() > at all? Just move that code into global_timer_of_register() and > also remove the #ifdef around CONFIG_OF and make the driver > depend on CONFIG_OF in Kconfig. > > After this you realize that all that business with > clk_register_clkdev() / clk_get_sys() is just pure surplus > baggade, you just use of_clk_get() and that's it. It makes sense to move all the code into global_timer_of_register(). This will also get rid of un-used code. I will do this in the next spin. Thanks, srini > > Yours, > Linus Walleij > _______________________________________________ > devicetree-discuss mailing list > devicetree-discuss at lists.ozlabs.org > https://lists.ozlabs.org/listinfo/devicetree-discuss >