All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Arend van Spriel" <arend@broadcom.com>
To: "Steven Rostedt" <rostedt@goodmis.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Tom Zanussi" <tom.zanussi@intel.com>,
	"Masami Hiramatsu" <masami.hiramatsu.pt@hitachi.com>
Subject: Re: event filtering with trace-cmd
Date: Wed, 12 Jun 2013 21:46:17 +0200	[thread overview]
Message-ID: <51B8D009.3010300@broadcom.com> (raw)
In-Reply-To: <1371057385.9844.261.camel@gandalf.local.home>

On 06/12/2013 07:16 PM, Steven Rostedt wrote:
> On Wed, 2013-06-12 at 12:22 -0400, Steven Rostedt wrote:
>
>>> # sudo trace-cmd record -e brcmfmac:brcmf_dbg -f 'level & 0x40000'
>>> disable all
>>> enable brcmfmac:brcmf_dbg
>>> path = /sys/kernel/debug/tracing/events/brcmfmac/brcmf_dbg/enable
>>> (level & 0x40000)
>>> ^
>>> parse_error: Invalid operator
>>>
>>
>> The record -f command passes the filter into the kernel
>> file /sys/kerne/debug/tracing/events/brcmfmac/brcmf_dbg/filter, and the
>> error is actually coming from the kernel itself. Looking at the code, we
>> do not currently accept binary operations. Although, it shouldn't be too
>> hard to add. I may go and implement it for 3.11.
>>
>
> Here, can you apply this patch and see if it does what you expect?

Not right now, but you can bet I will first thing tomorrow :-)

Thanks,
Arend

> Thanks,
>
> -- Steve
>
> diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
> index e1b653f..111eddf 100644
> --- a/kernel/trace/trace_events_filter.c
> +++ b/kernel/trace/trace_events_filter.c



  reply	other threads:[~2013-06-12 19:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-12 10:13 event filtering with trace-cmd Arend van Spriel
2013-06-12 16:22 ` Steven Rostedt
2013-06-12 17:16   ` Steven Rostedt
2013-06-12 19:46     ` Arend van Spriel [this message]
2013-06-14  8:22     ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51B8D009.3010300@broadcom.com \
    --to=arend@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=rostedt@goodmis.org \
    --cc=tom.zanussi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.