From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH qom-cpu v2 11/29] kvm: Change kvm_cpu_exec() argument to CPUState Date: Mon, 17 Jun 2013 18:17:05 +0200 Message-ID: <51BF3681.20002@redhat.com> References: <1371398269-6213-1-git-send-email-afaerber@suse.de> <1371398269-6213-12-git-send-email-afaerber@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Marcelo Tosatti , qemu-devel@nongnu.org, Gleb Natapov , Overall To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Return-path: In-Reply-To: <1371398269-6213-12-git-send-email-afaerber@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org Il 16/06/2013 17:57, Andreas Färber ha scritto: > Signed-off-by: Andreas Färber > --- > cpus.c | 2 +- > include/sysemu/kvm.h | 2 +- > kvm-all.c | 3 +-- > kvm-stub.c | 4 ++-- > 4 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/cpus.c b/cpus.c > index bbaf13c..47ab818 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -752,7 +752,7 @@ static void *qemu_kvm_cpu_thread_fn(void *arg) > > while (1) { > if (cpu_can_run(cpu)) { > - r = kvm_cpu_exec(env); > + r = kvm_cpu_exec(cpu); > if (r == EXCP_DEBUG) { > cpu_handle_guest_debug(env); > } > diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > index 5adb044..fe8bc40 100644 > --- a/include/sysemu/kvm.h > +++ b/include/sysemu/kvm.h > @@ -147,9 +147,9 @@ int kvm_has_gsi_routing(void); > int kvm_has_intx_set_mask(void); > > int kvm_init_vcpu(CPUState *cpu); > +int kvm_cpu_exec(CPUState *cpu); > > #ifdef NEED_CPU_H > -int kvm_cpu_exec(CPUArchState *env); > > #if !defined(CONFIG_USER_ONLY) > void *kvm_ram_alloc(ram_addr_t size); > diff --git a/kvm-all.c b/kvm-all.c > index 1675311..90b89cd 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -1602,9 +1602,8 @@ void kvm_cpu_synchronize_post_init(CPUState *cpu) > cpu->kvm_vcpu_dirty = false; > } > > -int kvm_cpu_exec(CPUArchState *env) > +int kvm_cpu_exec(CPUState *cpu) > { > - CPUState *cpu = ENV_GET_CPU(env); Always good to see some of these go. Acked-by: Paolo Bonzini > struct kvm_run *run = cpu->kvm_run; > int ret, run_ret; > > diff --git a/kvm-stub.c b/kvm-stub.c > index 50af700..5457fe8 100644 > --- a/kvm-stub.c > +++ b/kvm-stub.c > @@ -54,9 +54,9 @@ void kvm_cpu_synchronize_post_init(CPUState *cpu) > { > } > > -int kvm_cpu_exec(CPUArchState *env) > +int kvm_cpu_exec(CPUState *cpu) > { > - abort (); > + abort(); > } > > int kvm_has_sync_mmu(void) > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uoc7H-000232-A6 for qemu-devel@nongnu.org; Mon, 17 Jun 2013 12:17:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uoc7C-0008IH-GV for qemu-devel@nongnu.org; Mon, 17 Jun 2013 12:17:15 -0400 Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]:65047) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uoc7C-0008IC-AX for qemu-devel@nongnu.org; Mon, 17 Jun 2013 12:17:10 -0400 Received: by mail-wg0-f45.google.com with SMTP id j13so2624570wgh.24 for ; Mon, 17 Jun 2013 09:17:09 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <51BF3681.20002@redhat.com> Date: Mon, 17 Jun 2013 18:17:05 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1371398269-6213-1-git-send-email-afaerber@suse.de> <1371398269-6213-12-git-send-email-afaerber@suse.de> In-Reply-To: <1371398269-6213-12-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH qom-cpu v2 11/29] kvm: Change kvm_cpu_exec() argument to CPUState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Marcelo Tosatti , qemu-devel@nongnu.org, Gleb Natapov , Overall Il 16/06/2013 17:57, Andreas Färber ha scritto: > Signed-off-by: Andreas Färber > --- > cpus.c | 2 +- > include/sysemu/kvm.h | 2 +- > kvm-all.c | 3 +-- > kvm-stub.c | 4 ++-- > 4 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/cpus.c b/cpus.c > index bbaf13c..47ab818 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -752,7 +752,7 @@ static void *qemu_kvm_cpu_thread_fn(void *arg) > > while (1) { > if (cpu_can_run(cpu)) { > - r = kvm_cpu_exec(env); > + r = kvm_cpu_exec(cpu); > if (r == EXCP_DEBUG) { > cpu_handle_guest_debug(env); > } > diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > index 5adb044..fe8bc40 100644 > --- a/include/sysemu/kvm.h > +++ b/include/sysemu/kvm.h > @@ -147,9 +147,9 @@ int kvm_has_gsi_routing(void); > int kvm_has_intx_set_mask(void); > > int kvm_init_vcpu(CPUState *cpu); > +int kvm_cpu_exec(CPUState *cpu); > > #ifdef NEED_CPU_H > -int kvm_cpu_exec(CPUArchState *env); > > #if !defined(CONFIG_USER_ONLY) > void *kvm_ram_alloc(ram_addr_t size); > diff --git a/kvm-all.c b/kvm-all.c > index 1675311..90b89cd 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -1602,9 +1602,8 @@ void kvm_cpu_synchronize_post_init(CPUState *cpu) > cpu->kvm_vcpu_dirty = false; > } > > -int kvm_cpu_exec(CPUArchState *env) > +int kvm_cpu_exec(CPUState *cpu) > { > - CPUState *cpu = ENV_GET_CPU(env); Always good to see some of these go. Acked-by: Paolo Bonzini > struct kvm_run *run = cpu->kvm_run; > int ret, run_ret; > > diff --git a/kvm-stub.c b/kvm-stub.c > index 50af700..5457fe8 100644 > --- a/kvm-stub.c > +++ b/kvm-stub.c > @@ -54,9 +54,9 @@ void kvm_cpu_synchronize_post_init(CPUState *cpu) > { > } > > -int kvm_cpu_exec(CPUArchState *env) > +int kvm_cpu_exec(CPUState *cpu) > { > - abort (); > + abort(); > } > > int kvm_has_sync_mmu(void) >