From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35931)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Uoszl-0006lk-Ck
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 06:18:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Uoszj-0000TR-VS
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 06:18:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:28945)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Uoszj-0000TM-ON
	for qemu-devel@nongnu.org; Tue, 18 Jun 2013 06:18:35 -0400
Message-ID: <51C033C1.7080406@redhat.com>
Date: Tue, 18 Jun 2013 12:17:37 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20130606150618.10486.60669.stgit@hds.com>
	<20130606150702.10486.89130.stgit@hds.com>
In-Reply-To: <20130606150702.10486.89130.stgit@hds.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 10/10] QMP/qemu-ga-client: make timeout
 longer for guest-fsfreeze-freeze command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
Cc: libaiqing@huawei.com, mdroth@linux.vnet.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, vrozenfe@redhat.com, seiji.aguchi@hds.com, areis@redhat.com

Il 06/06/2013 17:07, Tomoki Sekiyama ha scritto:
> guest-fsfreeze-freeze command can take longer than 3 seconds when heavy
> disk I/O is running. To avoid unexpected timeout, this changes the timeout
> to 60 seconds (timeout of pre-commit phase of VSS).
> 
> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
> ---
>  QMP/qemu-ga-client |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/QMP/qemu-ga-client b/QMP/qemu-ga-client
> index 46676c3..b5f7e7c 100755
> --- a/QMP/qemu-ga-client
> +++ b/QMP/qemu-ga-client
> @@ -267,7 +267,9 @@ def main(address, cmd, args):
>              print('Hint: qemu is not running?')
>          sys.exit(1)
>  
> -    if cmd != 'ping':
> +    if cmd == 'fsfreeze' and args[0] == 'freeze':
> +        client.sync(60)
> +    elif cmd != 'ping':
>          client.sync()
>  
>      globals()['_cmd_' + cmd](client, args)
> 

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>