From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonyoung Shim Subject: Re: [PATCH 0/3] drm/cma: use prim helpers instead GEM CMA specific dma_buf functionality Date: Wed, 19 Jun 2013 10:47:40 +0900 Message-ID: <51C10DBC.7070001@samsung.com> References: <51B8749E.2070502@samsung.com> <3602404.et1JyG1OyE@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 82A72E5DF3 for ; Tue, 18 Jun 2013 18:47:30 -0700 (PDT) Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MOM00N8NAB21QG0@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 19 Jun 2013 10:47:28 +0900 (KST) In-reply-to: <3602404.et1JyG1OyE@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 06/19/2013 08:02 AM, Laurent Pinchart wrote: > Hi Joonyoung, > > On Wednesday 12 June 2013 22:16:14 Joonyoung Shim wrote: >> Hi, >> >> GEM CMA supports dma_buf but it needs GEM CMA specific functionality for >> dma_buf. We can use prime helpers for dma_buf by commit >> 89177644a7b6306e6084a89eab7e290f4bfef397 "drm: add prime helpers", so >> this patchset is to replace from using GEM CMA specific functions to >> using prime helpers. > Overall this looks good to me, except the that prime helpers don't cache > mappings, unlike the current implementation in the GEM CMA helpers. Could that > be fixed in the prime helpers first ? Right, i will update it first. Thanks.