From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40686)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Upyd8-0000Gw-Kr
	for qemu-devel@nongnu.org; Fri, 21 Jun 2013 06:31:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Upyd6-0005RF-8Q
	for qemu-devel@nongnu.org; Fri, 21 Jun 2013 06:31:46 -0400
Received: from cantor2.suse.de ([195.135.220.15]:41719 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Upyd6-0005Qu-3F
	for qemu-devel@nongnu.org; Fri, 21 Jun 2013 06:31:44 -0400
Message-ID: <51C42B8F.4050103@suse.de>
Date: Fri, 21 Jun 2013 12:31:43 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1371398269-6213-1-git-send-email-afaerber@suse.de>
	<1371398269-6213-19-git-send-email-afaerber@suse.de>
	<51BF72E5.5070003@twiddle.net>
In-Reply-To: <51BF72E5.5070003@twiddle.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-cpu v2 18/29] cpu: Turn
 cpu_unassigned_access() into a CPUState hook
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

Am 17.06.2013 22:34, schrieb Richard Henderson:
> On 06/16/2013 08:57 AM, Andreas F=C3=A4rber wrote:
>> +        cpu =3D CPU(alpha_env_get_cpu(cpu_single_env));
>> +        cs =3D CPU(alpha_env_get_cpu(cpu_single_env));
>> +    CPUState *cpu_single_cpu =3D CPU(alpha_env_get_cpu(cpu_single_env=
));
>> +        cs =3D CPU(alpha_env_get_cpu(cpu_single_env));
>=20
> ENV_GET_CPU.

Intentional, and all of these get replaced later on anyway.

>> +    cpu_class_set_do_unassigned_access(cc, alpha_cpu_unassigned_acces=
s);
>=20
> Wouldn't it be better to arrange for the function to exist always, with
> differing implementation for user and system, much like do_interrupt?

Sure, that would be possible. But determining what the user
implementation should do would be up to the target, i.e. you for alpha.

> What you've got is good enough for now, I suppose.

Thanks, v3 coming up.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg