From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzPhR-0000ym-W3 for qemu-devel@nongnu.org; Tue, 24 Jun 2014 08:19:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WzPhN-0000B3-GV for qemu-devel@nongnu.org; Tue, 24 Jun 2014 08:19:45 -0400 Received: from edge20.ethz.ch ([82.130.99.26]:59420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WzPhN-0000Ah-6u for qemu-devel@nongnu.org; Tue, 24 Jun 2014 08:19:41 -0400 From: "Aggeler Fabian" Date: Tue, 24 Jun 2014 12:19:39 +0000 Message-ID: <51C477A1-ADE4-4308-8B97-075E782EE815@ethz.ch> References: <1402444514-19658-1-git-send-email-aggelerf@ethz.ch> <1402444514-19658-6-git-send-email-aggelerf@ethz.ch> In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset="Windows-1252" Content-ID: <50128C09C115BB4E95C4F952BCF2BC13@intern.ethz.ch> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v3 05/32] target-arm: reject switching to monitor mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Bellows Cc: Peter Maydell , Peter Crosthwaite , QEMU Developers , Sergey Fedorov , "Edgar E. Iglesias" , Christoffer Dall Hm=85yes, this case is missing, but it is only missing for ARMv7 as this bi= t is RES0 in ARMv8. Even in ARMv7 it is IMPDEF whether this bit is supported. And since ARMv7 mentions, that this bit is deprecate= d from the introduction of Virtualization Extensions I did not care to add this special case. On 12 Jun 2014, at 23:55, Greg Bellows > wrote: Missing case where it is UNPREDICTABLE to enter FIQ mode from non-secure st= ate if NSACR.RFR is 1. On 10 June 2014 18:54, Fabian Aggeler > wrote: From: Sergey Fedorov > ...from non-secure state. Signed-off-by: Sergey Fedorov > Signed-off-by: Fabian Aggeler > --- target-arm/helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index d8d6637..ace8d8b 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -3049,6 +3049,8 @@ static int bad_mode_switch(CPUARMState *env, int mode= ) case ARM_CPU_MODE_IRQ: case ARM_CPU_MODE_FIQ: return 0; + case ARM_CPU_MODE_MON: + return !arm_is_secure(env); default: return 1; } -- 1.8.3.2