From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH 09/10] x86: check kexec relocation code fits
 in a page
Date: Tue, 25 Jun 2013 09:33:43 +0100
Message-ID: <51C9720702000078000E03A3@nat28.tlf.novell.com>
References: <1372095741-27012-1-git-send-email-david.vrabel@citrix.com>
	<1372095741-27012-10-git-send-email-david.vrabel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1372095741-27012-10-git-send-email-david.vrabel@citrix.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: David Vrabel <david.vrabel@citrix.com>
Cc: Daniel Kiper <daniel.kiper@oracle.com>, Keir Fraser <keir@xen.org>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

>>> On 24.06.13 at 19:42, David Vrabel <david.vrabel@citrix.com> wrote:
> --- a/xen/arch/x86/xen.lds.S
> +++ b/xen/arch/x86/xen.lds.S
> @@ -186,3 +186,7 @@ SECTIONS
>    .stab.indexstr 0 : { *(.stab.indexstr) }
>    .comment 0 : { *(.comment) }
>  }
> +
> +#ifdef CONFIG_KEXEC
> +ASSERT(__kexec_reloc_size <= PAGE_SIZE, "kexec control code is too large")
> +#endif

I don't recall having seen a mechanism to disable CONFIG_KEXEC, so
why the conditional?

Jan