From: Laszlo Ersek <lersek@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: libaiqing@huawei.com, qemu-devel@nongnu.org, stefanha@gmail.com,
mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com,
vrozenfe@redhat.com, Tomoki Sekiyama <tomoki.sekiyama@hds.com>,
seiji.aguchi@hds.com, areis@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 04/10] Add a script to extract VSS SDK headers on POSIX system
Date: Wed, 26 Jun 2013 12:52:16 +0200 [thread overview]
Message-ID: <51CAC7E0.5080304@redhat.com> (raw)
In-Reply-To: <51C9B0B1.7000508@redhat.com>
On 06/25/13 17:01, Paolo Bonzini wrote:
> Il 25/06/2013 17:01, Laszlo Ersek ha scritto:
>> On 06/06/13 17:06, Tomoki Sekiyama wrote:
>>
>>> +if ! command -v msiextract > /dev/null; then
>>> + echo 'msiextract not found. Please install msitools.' >&2
>>> + exit 1
>>> +fi
>>
>> (This is not a review comment -- I'm trying to test it:)
>>
>> What msiextract version (and dependencies, like libgcab, libgsf etc) are
>> you using? I'm unable to extract "vsssdk.msi"; msiextract spews a bunch
>> of assertion failures.
>>
>> 2e39646b7850a12673bc66ade85fece3 setup.exe
>> 433eb024ed0c669dd1563d952ca41091 vsssdk.msi
>>
>> My versions (RHEL-6.4.z distro):
>> - msitools-0.92 (built from source)
>> - gcab-0.4 (built from source)
>> - libgsf-1.14.15-5.el6 (patch in [1] doesn't seem to help, it only
>> changes the kinds of asserts that fail)
>> - glib2-2.22.5-7.el6
>> - libuuid-2.17.2-12.9.el6_4.3
>
> The attached patch may help building a newer libgsf on RHEL6.
It did help building it, however the runtime error has stayed. I'm
starting to worry this is a more fundamental issue, namely in glib.
The first errors I'm getting on the msiextract stderr are:
(msiextract:28858): GLib-GObject-WARNING **: invalid cast from
`GDataInputStream' to `GSeekable'
(msiextract:28858): GLib-GIO-CRITICAL **: g_seekable_seek: assertion
`G_IS_SEEKABLE (seekable)' failed
(The second clearly being a consequence of the first.)
Problem is, the first warning is "wrong". According to the current, live
glib docs <https://developer.gnome.org/gio/stable/GDataInputStream.html>,
GDataInputStream implements GSeekable.
The NEWS file in glib states,
Overview of changes from GLib 2.32.1 to 2.33.1
==============================================
[...]
* GIO:
- implement GSeekable for the data and buffered stream classes
Commits:
git log --oneline --reverse 2.32.1..2.33.1 | grep -i seekable
90739ba Make GBufferedInputStream implement GSeekable
43895e3 Make GBufferedOutputStream implement GSeekable
a44e801 Make GDataOutputStream implement GSeekable
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=673034
GDataOutputStream and GBufferedOutputStream are both direct descendants
of GFilterOutputStream, and they both implement the GSeekable interface
in isolation.
However GDataInputStream is derived from GBufferedInputStream (it the
former is not the sibling of the latter, as for output).
GBufferedInputStream was made to implement GSeekable explicitly, and
GDataInputStream gets it via inheritance. (In 2.33.1, that is.)
I guess I'll extract the MSI once on F19 and stash the contents...
Thanks!
Laszlo
next prev parent reply other threads:[~2013-06-26 10:50 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 15:06 [Qemu-devel] [PATCH v4 00/10] qemu-ga: fsfreeze on Windows using VSS Tomoki Sekiyama
2013-06-06 15:06 ` [Qemu-devel] [PATCH v4 01/10] configure: Support configuring c++ compiler Tomoki Sekiyama
2013-06-18 10:17 ` Paolo Bonzini
2013-06-25 8:15 ` Laszlo Ersek
2013-06-06 15:06 ` [Qemu-devel] [PATCH v4 02/10] Add c++ keywords to QAPI helper script Tomoki Sekiyama
2013-06-25 8:16 ` Laszlo Ersek
2013-06-06 15:06 ` [Qemu-devel] [PATCH v4 03/10] checkpatch.pl: check .cpp files Tomoki Sekiyama
2013-06-25 8:17 ` Laszlo Ersek
2013-06-06 15:06 ` [Qemu-devel] [PATCH v4 04/10] Add a script to extract VSS SDK headers on POSIX system Tomoki Sekiyama
2013-06-25 8:30 ` Laszlo Ersek
2013-06-25 15:01 ` Laszlo Ersek
2013-06-25 15:01 ` Paolo Bonzini
2013-06-26 10:52 ` Laszlo Ersek [this message]
2013-06-06 15:06 ` [Qemu-devel] [PATCH v4 05/10] qemu-ga: Add configure options to specify path to Windows/VSS SDK Tomoki Sekiyama
2013-06-25 11:16 ` Laszlo Ersek
2013-06-28 10:43 ` Daniel P. Berrange
2013-06-28 10:54 ` Paolo Bonzini
2013-06-28 11:01 ` Daniel P. Berrange
2013-06-28 11:18 ` Paolo Bonzini
2013-06-28 11:30 ` Daniel P. Berrange
2013-06-28 12:18 ` Paolo Bonzini
2013-06-28 11:05 ` Laszlo Ersek
2013-06-06 15:06 ` [Qemu-devel] [PATCH v4 06/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze Tomoki Sekiyama
2013-06-25 16:03 ` Laszlo Ersek
2013-06-25 16:19 ` Paolo Bonzini
2013-06-25 18:23 ` Tomoki Sekiyama
2013-06-25 18:59 ` Paolo Bonzini
2013-06-25 19:28 ` Tomoki Sekiyama
2013-06-25 19:52 ` Laszlo Ersek
2013-06-26 14:32 ` Laszlo Ersek
2013-06-26 21:27 ` Paolo Bonzini
2013-06-26 22:09 ` Tomoki Sekiyama
2013-06-27 15:01 ` Laszlo Ersek
2013-06-27 22:25 ` Tomoki Sekiyama
2013-06-28 7:05 ` Paolo Bonzini
2013-06-28 10:40 ` Laszlo Ersek
2013-06-28 10:40 ` Paolo Bonzini
2013-06-28 17:18 ` Tomoki Sekiyama
2013-06-28 10:44 ` Laszlo Ersek
2013-06-25 21:15 ` Paolo Bonzini
2013-06-25 22:31 ` Tomoki Sekiyama
2013-06-26 5:59 ` Paolo Bonzini
2013-06-26 14:13 ` Tomoki Sekiyama
2013-06-30 13:16 ` Gal Hammer
2013-07-01 18:57 ` Tomoki Sekiyama
2013-07-02 12:36 ` Gal Hammer
2013-06-06 15:06 ` [Qemu-devel] [PATCH v4 07/10] qemu-ga: Add Windows VSS requester to quiesce applications and filesystems Tomoki Sekiyama
2013-06-28 18:01 ` Laszlo Ersek
2013-06-28 18:34 ` Laszlo Ersek
2013-06-30 1:21 ` Tomoki Sekiyama
2013-07-01 8:31 ` Laszlo Ersek
2013-06-06 15:06 ` [Qemu-devel] [PATCH v4 08/10] qemu-ga: call Windows VSS requester in fsfreeze command handler Tomoki Sekiyama
2013-07-01 13:29 ` Laszlo Ersek
2013-07-01 17:48 ` Eric Blake
2013-07-01 17:59 ` Tomoki Sekiyama
2013-07-02 6:36 ` Laszlo Ersek
2013-07-02 14:09 ` Luiz Capitulino
2013-07-02 14:44 ` Laszlo Ersek
2013-07-02 15:16 ` Luiz Capitulino
2013-07-02 15:28 ` Laszlo Ersek
2013-07-02 14:58 ` Michael Roth
2013-06-06 15:06 ` [Qemu-devel] [PATCH v4 09/10] qemu-ga: install Windows VSS provider on `qemu-ga -s install' Tomoki Sekiyama
2013-07-01 14:50 ` Laszlo Ersek
2013-07-01 17:59 ` Tomoki Sekiyama
2013-06-06 15:07 ` [Qemu-devel] [PATCH v4 10/10] QMP/qemu-ga-client: make timeout longer for guest-fsfreeze-freeze command Tomoki Sekiyama
2013-06-18 10:17 ` Paolo Bonzini
2013-07-01 15:02 ` Laszlo Ersek
2013-06-10 9:26 ` [Qemu-devel] [PATCH v4 00/10] qemu-ga: fsfreeze on Windows using VSS Stefan Hajnoczi
2013-06-24 19:30 ` Tomoki Sekiyama
2013-06-24 21:13 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CAC7E0.5080304@redhat.com \
--to=lersek@redhat.com \
--cc=areis@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=libaiqing@huawei.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seiji.aguchi@hds.com \
--cc=stefanha@gmail.com \
--cc=tomoki.sekiyama@hds.com \
--cc=vrozenfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.