From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Subject: Re: [Qemu-devel] [PATCH qom-cpu v2 20/29] kvm: Change kvm_remove_all_breakpoints() argument to CPUState Date: Thu, 27 Jun 2013 17:58:03 +0200 Message-ID: <51CC610B.4040107@suse.de> References: <1371398269-6213-1-git-send-email-afaerber@suse.de> <1371398269-6213-21-git-send-email-afaerber@suse.de> <51BF36B1.1030505@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Marcelo Tosatti , qemu-devel@nongnu.org, Gleb Natapov , kvm To: Paolo Bonzini Return-path: Received: from cantor2.suse.de ([195.135.220.15]:49113 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753258Ab3F0P6G (ORCPT ); Thu, 27 Jun 2013 11:58:06 -0400 In-Reply-To: <51BF36B1.1030505@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Am 17.06.2013 18:17, schrieb Paolo Bonzini: > Il 16/06/2013 17:57, Andreas F=C3=A4rber ha scritto: >> Signed-off-by: Andreas F=C3=A4rber >> --- >> gdbstub.c | 2 +- >> include/sysemu/kvm.h | 2 +- >> kvm-all.c | 5 ++--- >> kvm-stub.c | 2 +- >> 4 files changed, 5 insertions(+), 6 deletions(-) >> >> diff --git a/gdbstub.c b/gdbstub.c >> index 3101a43..9e7f7a1 100644 >> --- a/gdbstub.c >> +++ b/gdbstub.c >> @@ -2019,7 +2019,7 @@ static void gdb_breakpoint_remove_all(void) >> CPUArchState *env; >> =20 >> if (kvm_enabled()) { >> - kvm_remove_all_breakpoints(gdbserver_state->c_cpu); >> + kvm_remove_all_breakpoints(ENV_GET_CPU(gdbserver_state->c_c= pu)); >=20 > Planning to make gdbserver_state take a CPUState, too? Yes, I'm still working on that: The qom-cpu-11 series is already about as large as this one and still has only two out of three CPUArchState fields converted. ;) Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3= =BCrnberg