From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsGGG-0001e4-Ng for qemu-devel@nongnu.org; Thu, 27 Jun 2013 13:45:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsGGE-0002Om-Ul for qemu-devel@nongnu.org; Thu, 27 Jun 2013 13:45:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35685) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsGGE-0002OV-7S for qemu-devel@nongnu.org; Thu, 27 Jun 2013 13:45:34 -0400 Message-ID: <51CC7A3A.5000204@redhat.com> Date: Thu, 27 Jun 2013 11:45:30 -0600 From: Eric Blake MIME-Version: 1.0 References: <1372078125-31085-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1372078125-31085-2-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1372078125-31085-2-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2NGHBBCWUOOXXEOQCMBJD" Subject: Re: [Qemu-devel] [PATCH V2 1/7] monitor: discard global variable *cur_mon in completion functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: pbonzini@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2NGHBBCWUOOXXEOQCMBJD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/24/2013 06:48 AM, Wenchao Xia wrote: > Parameter *mon is added to replace *cur_mon, and readline_completion() > pass rs->mon as value, which should be initialized in readline_init() > called by monitor_init(). In short, structure ReadLineState controls > where the action would be taken now. >=20 > Signed-off-by: Wenchao Xia > --- > +static void monitor_find_completion(Monitor *mon, > + const char *cmdline) > { > const char *cmdname; > char *args[MAX_ARGS]; > int nb_args, i, len; > const char *ptype, *str; > const mon_cmd_t *cmd; > + MonitorBlockComplete mbs; > =20 > parse_cmdline(cmdline, &nb_args, args); > #ifdef DEBUG_COMPLETION > for(i =3D 0; i < nb_args; i++) { > - monitor_printf(cur_mon, "arg%d =3D '%s'\n", i, (char *)args[i]= ); > + monitor_printf(mon, "arg%d =3D '%s'\n", i, (char *)args[i]); Pre-existing, but that cast to (char*) looks pointless, since args[i] is already typed as 'char *'. Might as well remove it while touching this line. Looks like a decent refactor; Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2NGHBBCWUOOXXEOQCMBJD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRzHo6AAoJEKeha0olJ0NqPbkH/jYxznIH/3UNTc0XGWnB7xTj 8bn0Az2mDXZZ6ZlPyU8XY14ZnUn8PiYKvnuYk8kVmm5xM6dCmTWj+5f31JzFIh3t hzgIfaBrR8JzzMlz4aX2wJwRSHxpzd+Fg8AeynKmrS5yk5OWCNt3wQkoyVpJbZAm ALaI0mrgumeMW6PUUSNSuCdbp/4bD/RahCl/HQfC2bdHqMthNEV9+Dx7499dwDu4 K+4UWk0je6FoS6bzUlgYn4WmTeEkq/OWcbos4riyMJ+zjHOggYaad5jxlbrYGm7W 2ACF5lHk0tGIBcstr275yqWN7iVDmYGfQSb/UYPpmScUeGuU8QKHDqMg+FeYIL0= =F/lN -----END PGP SIGNATURE----- ------enig2NGHBBCWUOOXXEOQCMBJD--