From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsLRx-0005Pf-Fa for qemu-devel@nongnu.org; Thu, 27 Jun 2013 19:18:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsLRw-00083q-7x for qemu-devel@nongnu.org; Thu, 27 Jun 2013 19:18:01 -0400 Message-ID: <51CCC824.9080701@redhat.com> Date: Thu, 27 Jun 2013 17:17:56 -0600 From: Eric Blake MIME-Version: 1.0 References: <1372342930-28684-1-git-send-email-armbru@redhat.com> <1372342930-28684-2-git-send-email-armbru@redhat.com> In-Reply-To: <1372342930-28684-2-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2KCFXGXWSKQNPDDGKOHTD" Subject: Re: [Qemu-devel] [PATCH 1/4] qemu-char: Fix ringbuf option size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: aliguori@us.ibm.com, lilei@linux.vnet.ibm.com, qemu-stable@nongnu.org, qemu-devel@nongnu.org, lcapitulino@redhat.com, kraxel@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2KCFXGXWSKQNPDDGKOHTD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/27/2013 08:22 AM, Markus Armbruster wrote: > Any attempt to use it trips an "opt->desc->type =3D=3D QEMU_OPT_NUMBER"= > assertion. Broken in commit 1da48c65. >=20 > Cc: qemu-stable@nongnu.org > Signed-off-by: Markus Armbruster > --- > qemu-char.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake >=20 > diff --git a/qemu-char.c b/qemu-char.c > index 63972ae..63a9221 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -3108,7 +3108,7 @@ static void qemu_chr_parse_memory(QemuOpts *opts,= ChardevBackend *backend, > =20 > backend->memory =3D g_new0(ChardevMemory, 1); > =20 > - val =3D qemu_opt_get_number(opts, "size", 0); > + val =3D qemu_opt_get_size(opts, "size", 0); > if (val !=3D 0) { > backend->memory->has_size =3D true; > backend->memory->size =3D val; >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2KCFXGXWSKQNPDDGKOHTD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRzMgkAAoJEKeha0olJ0NqeuAH/R/nCdW3qpn/KOdZlLZWox9c h4VBxX+1b8zhgLjACuuhAX0jX/vVbMoySqLXih/MNqPITcSQ5SK/yhq/umdzZ/qB pfusXe7OxNPSaJw41cBO1454BPs4ffzoatHRi3RrAMh0e99v7P+ZphQOH71YtEdk FKaA6LEVy2HH8IEE9yap/g7UFAHBN2bBVgXlQUUXohjWM9VQ0ZQEHVb0UrpOYTVU UBGeGXIu7Jep+tTpAwrP+I0oO+b+ZHORpztg61tWDSTfWLmQzj/H/rKiWqF2nGMH 7Qgx4XHuQFKzZwuV65SfzMzuySdaMu8YDuXGGHRE/Y0N7Se4UMxPB/mQ99SXVqY= =9U9l -----END PGP SIGNATURE----- ------enig2KCFXGXWSKQNPDDGKOHTD--