From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?windows-1252?Q?Andreas_Bie=DFmann?= <andreas.devel@googlemail.com>
Date: Fri, 28 Jun 2013 08:48:48 +0200
Subject: [U-Boot] [PATCH] mkimage: Build signing only if board has
	CONFIG_FIT_SIGNATURE
In-Reply-To: <1372354998-22542-1-git-send-email-sjg@chromium.org>
References: <1372354998-22542-1-git-send-email-sjg@chromium.org>
Message-ID: <51CD31D0.8050905@googlemail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon,

On 27.06.13 19:43, Simon Glass wrote:
> At present mkimage is set up to always build with image signing support.
> This means that the SSL libraries (e.g. libssl-dev) are always required.
> 
> Adjust things so that mkimage can be built with and without image signing,
> controlled by the presence of CONFIG_FIT_SIGNATURE in the board config file.
> 
> If CONFIG_FIT_SIGNATURE is not enabled, then mkimage will report a warning
> that signing is not supported. If the option is enabled, but libraries are
> not available, then a build error similar to this will be shown:
> 
> lib/rsa/rsa-sign.c:26:25: fatal error: openssl/rsa.h: No such file or directory
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>  config.mk       | 6 +++++-
>  include/image.h | 3 ---
>  tools/Makefile  | 2 +-
>  3 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/config.mk b/config.mk
> index 5a91203..81c2584 100644
> --- a/config.mk
> +++ b/config.mk
> @@ -96,7 +96,6 @@ HOSTCFLAGS	+= $(call os_x_before, 10, 4, "-traditional-cpp")
>  HOSTLDFLAGS	+= $(call os_x_before, 10, 5, "-multiply_defined suppress")
>  else
>  HOSTCC		= gcc
> -HOSTLIBS	+= -lssl -lcrypto
>  endif
>  
>  ifeq ($(HOSTOS),cygwin)
> @@ -211,6 +210,11 @@ CPPFLAGS += -ffunction-sections -fdata-sections
>  LDFLAGS_FINAL += --gc-sections
>  endif
>  
> +# TODO(sjg at chromium.org): Is this correct on Mac OS?

I'll check it these days. Unfortunately regex is behaving differently on
OS X too, so prooftool.c is not compiling:

---8<---
proftool.c: In function ?check_trace_config_line?:
proftool.c:336: error: ?REG_NOERROR? undeclared (first use in this function)
--->8---

I'll check this too.

Best regards

Andreas Bie?mann