From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsW6W-0003Wl-Kk for qemu-devel@nongnu.org; Fri, 28 Jun 2013 06:40:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UsW6V-0006DQ-Nd for qemu-devel@nongnu.org; Fri, 28 Jun 2013 06:40:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UsW6V-0006DE-Fu for qemu-devel@nongnu.org; Fri, 28 Jun 2013 06:40:35 -0400 Message-ID: <51CD6814.8070501@redhat.com> Date: Fri, 28 Jun 2013 12:40:20 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <51CD35C4.5000802@redhat.com> <51CD681A.6030500@redhat.com> In-Reply-To: <51CD681A.6030500@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 06/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: "libaiqing@huawei.com" , "mdroth@linux.vnet.ibm.com" , "stefanha@gmail.com" , "qemu-devel@nongnu.org" , "lcapitulino@redhat.com" , "vrozenfe@redhat.com" , Tomoki Sekiyama , Seiji Aguchi , "areis@redhat.com" Il 28/06/2013 12:40, Laszlo Ersek ha scritto: >> > Also, this is not running in the context of qemu-ga, so I think it is >> > better to be more conservative and trap memory allocation failure. > In that case other "new" calls must assume the nothrow form too, plus > other allocation functions should be checked as well (eg. > SysAllocStringLen(), although its only use might be in the function that > Tomoki plans to remove anyway). Agreed (nothrow or try...catch, depending on what's better for the C++ runtime; by the way, Tomoki-san, I suspect this will require libstdc++ when compiled with GCC---can you confirm?). Thanks, Paolo