From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755907Ab3F1RTO (ORCPT ); Fri, 28 Jun 2013 13:19:14 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:48387 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755526Ab3F1RTN (ORCPT ); Fri, 28 Jun 2013 13:19:13 -0400 Message-ID: <51CDC589.8070306@gmail.com> Date: Fri, 28 Jun 2013 11:19:05 -0600 From: David Ahern User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Adrian Hunter CC: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Frederic Weisbecker , Jiri Olsa , Mike Galbraith , Namhyung Kim , Paul Mackerras , Peter Zijlstra , Stephane Eranian Subject: Re: [PATCH V3 06/15] perf tools: fix parse_events_terms() freeing local variable on error path References: <1372409006-8431-1-git-send-email-adrian.hunter@intel.com> <1372409006-8431-7-git-send-email-adrian.hunter@intel.com> In-Reply-To: <1372409006-8431-7-git-send-email-adrian.hunter@intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/28/13 2:43 AM, Adrian Hunter wrote: > The list_head is on the stack, so just free the rest of the list. > > Signed-off-by: Adrian Hunter > --- > tools/perf/util/parse-events.c | 7 ++++++- > tools/perf/util/parse-events.h | 1 + > tools/perf/util/pmu.c | 2 +- > 3 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c > index 995fc25..d9cb055 100644 > --- a/tools/perf/util/parse-events.c > +++ b/tools/perf/util/parse-events.c > @@ -1231,12 +1231,17 @@ int parse_events_term__clone(struct parse_events_term **new, > term->val.str, term->val.num); > } > > -void parse_events__free_terms(struct list_head *terms) > +void parse_events__free_terms_only(struct list_head *terms) > { > struct parse_events_term *term, *h; > > list_for_each_entry_safe(term, h, terms, list) > free(term); > +} > + > +void parse_events__free_terms(struct list_head *terms) > +{ > + parse_events__free_terms_only(terms); > > free(terms); > } I still don't understand the reasoning for an _only function. There is only 1 place that mallocs the list_head and that 1 user should free its own memory. All of the other users pass a stack variable. David