From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41290)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1UsfHm-0001BN-Ad
	for qemu-devel@nongnu.org; Fri, 28 Jun 2013 16:28:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1UsfHl-0002OC-Be
	for qemu-devel@nongnu.org; Fri, 28 Jun 2013 16:28:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:32620)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1UsfHl-0002O5-2g
	for qemu-devel@nongnu.org; Fri, 28 Jun 2013 16:28:49 -0400
Message-ID: <51CDF1FD.20205@redhat.com>
Date: Fri, 28 Jun 2013 14:28:45 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <cover.1372234719.git.hutao@cn.fujitsu.com>
	<e0ba243cf24c6044000ed3975390122e87d529f3.1372234719.git.hutao@cn.fujitsu.com>
In-Reply-To: <e0ba243cf24c6044000ed3975390122e87d529f3.1372234719.git.hutao@cn.fujitsu.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="----enig2QREGNVSIJASCAIASNGRG"
Subject: Re: [Qemu-devel] [PATCH v5 14/14] Implement dimm-info
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hu Tao <hutao@cn.fujitsu.com>
Cc: Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>, qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
------enig2QREGNVSIJASCAIASNGRG
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 06/26/2013 03:13 AM, Hu Tao wrote:
> From: Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>
>=20
> "query-dimm-info" and "info dimm" will give current state of all dimms =
in the
> system e.g.
>=20

> +++ b/qapi-schema.json
> @@ -3621,3 +3621,30 @@
>  { 'type': 'MemoryInfo',
>    'data': { 'total': 'int' } }
>  { 'command': 'query-memory', 'returns': 'MemoryInfo' }
> +
> +##
> +# @DimmInfo:
> +#
> +# Information about status of dimm device
> +#
> +# @dimm: the name of the dimm
> +#
> +# @state: 'true' means the dimm device is plugged in, 'false' means
> +#         means the dimm device is plugged out.

s/plugged out/unplugged/

> +#
> +# Since: 1.6
> +#
> +##
> +{ 'type': 'DimmInfo',
> +  'data': {'dimm': 'str', 'state': 'bool'} }
> +
> +##
> +# @query-dimm-info:
> +#
> +# Returns the state of dimm devices
> +#
> +# Returns: list of @DimmInfo
> +#
> +# Since: 1.6
> +##
> +{ 'command': 'query-dimm-info', 'returns': ['DimmInfo'] }

Looks good from an interface perspective; but missing an example in
qmp-commands.hx.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


------enig2QREGNVSIJASCAIASNGRG
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJRzfH9AAoJEKeha0olJ0NqWvIH/0Lz+oGPAln4GpwtNnhOvNe1
F91x4uh2hHMmdnb6wCSamZRuai4IBbJgWDXuDrmu5JR6lWfRctzm4ZyGoZpP6MH8
LmCcBox/0AL8ziMKvfN1a9FhsmtQPKh2H0Q10A5wHfQncFVqnDB+Cb3a3NFVktwG
dOl2AgOWF2Rq2Y/0WifkCrzzMn6Pb5jXslDKk5sdyPdu2MZ8aQLudLeGU9HfUb5o
9xP9QwWED9+02xj4m+pIthUSS7A4l69nNFkvPryB7EqhSze5g7MZWGK6TeEGtL/f
zm1Rt0xhhhz7aZe+iHODUm6rb1NrxVhqbGZ1UTb20L8ofUJd+/XBPixm5Ww78UU=
=HGub
-----END PGP SIGNATURE-----

------enig2QREGNVSIJASCAIASNGRG--