From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtHTo-0004cF-US for qemu-devel@nongnu.org; Sun, 30 Jun 2013 09:15:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtHTn-0000wR-W7 for qemu-devel@nongnu.org; Sun, 30 Jun 2013 09:15:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtHTn-0000wJ-Bg for qemu-devel@nongnu.org; Sun, 30 Jun 2013 09:15:47 -0400 Message-ID: <51D02FC1.7080002@redhat.com> Date: Sun, 30 Jun 2013 16:16:49 +0300 From: Gal Hammer MIME-Version: 1.0 References: <20130606150618.10486.60669.stgit@hds.com> <20130606150645.10486.23215.stgit@hds.com>, <51CA0874.1000402@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 06/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tomoki Sekiyama Cc: "libaiqing@huawei.com" , "mdroth@linux.vnet.ibm.com" , "stefanha@gmail.com" , "qemu-devel@nongnu.org" , "lcapitulino@redhat.com" , "vrozenfe@redhat.com" , Paolo Bonzini , Seiji Aguchi , "areis@redhat.com" On 26/06/2013 01:31, Tomoki Sekiyama wrote: >> Also, is it needed to call VSSCheckOSVersion from the requestor? I >> would think that checking VSSAPI.DLL is stronger than checking the >> version, and indeed you do that check too. > > In Windows XP, VSSAPI.DLL exists but it has different functionality > and interfaces from newer Windows. > http://msdn.microsoft.com/en-us/library/windows/desktop/aa384627(v=vs.85).aspx > > It is checking the OS version because this patchset only supports > Windows 2003 or later. So why don't you query for the interface you supports rather than checking the OS version? Thanks, Gal. > Thanks, > Tomoki Sekiyama >