From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtZUC-0006xR-Jh for qemu-devel@nongnu.org; Mon, 01 Jul 2013 04:29:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UtZUA-0001G2-0S for qemu-devel@nongnu.org; Mon, 01 Jul 2013 04:29:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UtZU9-0001Fs-Pw for qemu-devel@nongnu.org; Mon, 01 Jul 2013 04:29:21 -0400 Message-ID: <51D13E6A.9050908@redhat.com> Date: Mon, 01 Jul 2013 10:31:38 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 07/10] qemu-ga: Add Windows VSS requester to quiesce applications and filesystems List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tomoki Sekiyama Cc: "libaiqing@huawei.com" , "mdroth@linux.vnet.ibm.com" , "stefanha@gmail.com" , "qemu-devel@nongnu.org" , "lcapitulino@redhat.com" , "vrozenfe@redhat.com" , "pbonzini@redhat.com" , Seiji Aguchi , "areis@redhat.com" On 06/30/13 03:21, Tomoki Sekiyama wrote: > On 6/28/13 14:01 , "Laszlo Ersek" wrote: >> On 06/06/13 17:06, Tomoki Sekiyama wrote: >>> +static t_CreateVssBackupComponents _CreateVssBackupComponents; >>> +static t_VssFreeSnapshotProperties _VssFreeSnapshotProperties; >> Unless there's a pressing reason, could you drop the leading >> underscores? > > Oh, I didn't know that. Without underscores, they conflict with function > declared in the MinGW header. Maybe pCreateVssBackupComponents? Sure. I hope to start reviewing the next patch soonish. Thanks! Laszlo