From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Utdmi-0002tY-TF for qemu-devel@nongnu.org; Mon, 01 Jul 2013 09:04:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Utdmh-0002CI-52 for qemu-devel@nongnu.org; Mon, 01 Jul 2013 09:04:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60810) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Utdmg-0002By-TP for qemu-devel@nongnu.org; Mon, 01 Jul 2013 09:04:47 -0400 Message-ID: <51D17E6B.9050503@redhat.com> Date: Mon, 01 Jul 2013 15:04:43 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1372444009-11544-1-git-send-email-pbonzini@redhat.com> <1372444009-11544-5-git-send-email-pbonzini@redhat.com> <8761wy9ded.fsf@codemonkey.ws> <51D15830.5080504@redhat.com> <87li5q4epp.fsf@codemonkey.ws> In-Reply-To: <87li5q4epp.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/30] add a header file for atomic operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org Il 01/07/2013 15:00, Anthony Liguori ha scritto: >> I >> > cannot find the commit exactly, but I think mst added specific code for >> > that. > Right, I'm not questioning whether these functions have strong enough > semantics in their implementation, but asking what their contract should > be. > > Either we should document that these functions have atomic semantics or > we should introduce another variant that guarantee atomic access. > > I think the later makes more sense since the majority of users probably > don't need atomic semantics. I think many of these loads and stores do, actually; perhaps most. It also matches what hardware does. Paolo