From: Paolo Bonzini <pbonzini@redhat.com>
To: Ian Main <imain@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V1 1/2] Implement sync modes for drive-backup.
Date: Thu, 04 Jul 2013 09:45:41 +0200 [thread overview]
Message-ID: <51D52825.5080803@redhat.com> (raw)
In-Reply-To: <20130703181454.GC7462@gate.mains.priv>
Il 03/07/2013 20:14, Ian Main ha scritto:
>> >
>> > Should the source be "bs" for MIRROR_SYNC_MODE_NONE? Also in this case
>> > you may want to default the format to "qcow2" instead of bs's format.
> I'm not sure that it matters what the source is for NONE. Since we are
> copying all new writes, whether they would go to a top-most layer or not
> shouldn't matter?
It would matter for reads of still-uncopied data, though. You have to
read from the topmost layer, not the one below.
> As for qcow2 format, there is a 'format' option to the drive-backup API
> which specifies the format. I guess we could set the default to qcow2
> instead of the source format? Anyone have any opinions on that?
That would be another possibility. Perhaps use qcow2 for top or none,
and the source format for full.
> I have made the other changes above done. If I don't hear on this issue
> soon I'll post another revision.
You can go ahead and post anyway (just remember to fix the backing file
issue), it is a simple patch on top of what you have.
Paolo
next prev parent reply other threads:[~2013-07-04 7:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 2:28 [Qemu-devel] [PATCH V1 0/2] Implement sync modes for drive-backup Ian Main
2013-06-28 2:28 ` [Qemu-devel] [PATCH V1 1/2] " Ian Main
2013-07-01 12:16 ` Paolo Bonzini
2013-07-03 18:14 ` Ian Main
2013-07-04 7:45 ` Paolo Bonzini [this message]
2013-07-08 9:21 ` Fam Zheng
2013-07-15 10:50 ` Paolo Bonzini
2013-07-15 17:49 ` Ian Main
2013-07-15 20:47 ` Paolo Bonzini
2013-07-16 18:17 ` Ian Main
2013-06-28 2:28 ` [Qemu-devel] [PATCH V1 2/2] Add tests for sync modes 'TOP' and 'NONE' Ian Main
2013-07-04 13:20 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D52825.5080803@redhat.com \
--to=pbonzini@redhat.com \
--cc=imain@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.