From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755247Ab3GDNj0 (ORCPT ); Thu, 4 Jul 2013 09:39:26 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:37998 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751781Ab3GDNjY (ORCPT ); Thu, 4 Jul 2013 09:39:24 -0400 Message-ID: <51D57AF9.2020001@ti.com> Date: Thu, 4 Jul 2013 19:09:05 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Sebastian Andrzej Siewior CC: Lee Jones , Samuel Ortiz , =?UTF-8?B?QmVub8OudCBDb3Vzc29u?= , Tony Lindgren , Jonathan Cameron , Dmitry Torokhov , Felipe Balbi , , , , Subject: Re: [PATCH 04/22] input/ti_am33x_tsc: Order of TSC wires, made configurable References: <1370950268-7224-1-git-send-email-bigeasy@linutronix.de> <1370950268-7224-5-git-send-email-bigeasy@linutronix.de> <51D5592F.6050208@ti.com> <51D55D80.6080803@linutronix.de> In-Reply-To: <51D55D80.6080803@linutronix.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/4/2013 5:03 PM, Sebastian Andrzej Siewior wrote: > On 07/04/2013 01:14 PM, Sekhar Nori wrote: >> >> On 6/11/2013 5:00 PM, Sebastian Andrzej Siewior wrote: >>> From: "Patil, Rachna" >>> >>> The current driver expected touchscreen input >>> wires(XP,XN,YP,YN) to be connected in a particular order. >>> Making changes to accept this as platform data >> >> The platform data part of this driver will never get used since it is >> used on DT-only platforms (and future platforms will all be DT-only). >> You should get rid of it as it will save you some code. > > If you follow the series you will notice that the platform bits are > removed later. Should I have overlooked something please say so. Yes, I noticed that after sending the mail. To me it does not make sense to make changes to accept something as platform data only to remove platform data itself later. May be reorder the series to move this to after platform data removal - that way any platform data related changes in the patch will have to go away. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH 04/22] input/ti_am33x_tsc: Order of TSC wires, made configurable Date: Thu, 4 Jul 2013 19:09:05 +0530 Message-ID: <51D57AF9.2020001@ti.com> References: <1370950268-7224-1-git-send-email-bigeasy@linutronix.de> <1370950268-7224-5-git-send-email-bigeasy@linutronix.de> <51D5592F.6050208@ti.com> <51D55D80.6080803@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51D55D80.6080803-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sebastian Andrzej Siewior Cc: Lee Jones , Samuel Ortiz , =?UTF-8?B?QmVub8OudCBDb3Vzc29u?= , Tony Lindgren , Jonathan Cameron , Dmitry Torokhov , Felipe Balbi , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-input@vger.kernel.org On 7/4/2013 5:03 PM, Sebastian Andrzej Siewior wrote: > On 07/04/2013 01:14 PM, Sekhar Nori wrote: >> >> On 6/11/2013 5:00 PM, Sebastian Andrzej Siewior wrote: >>> From: "Patil, Rachna" >>> >>> The current driver expected touchscreen input >>> wires(XP,XN,YP,YN) to be connected in a particular order. >>> Making changes to accept this as platform data >> >> The platform data part of this driver will never get used since it is >> used on DT-only platforms (and future platforms will all be DT-only). >> You should get rid of it as it will save you some code. > > If you follow the series you will notice that the platform bits are > removed later. Should I have overlooked something please say so. Yes, I noticed that after sending the mail. To me it does not make sense to make changes to accept something as platform data only to remove platform data itself later. May be reorder the series to move this to after platform data removal - that way any platform data related changes in the patch will have to go away. Thanks, Sekhar