From: Dion Kant <g.w.kant@hunenet.nl>
To: Wei Liu <wei.liu2@citrix.com>
Cc: jbeulich@suse.com, xen-devel@lists.xen.org
Subject: Re: [Xen-users] kernel 3.9.2 - xen 4.2.2/4.3rc1 => BUG unable to handle kernel paging request netif_poll+0x49c/0xe8
Date: Fri, 05 Jul 2013 21:11:08 +0200 [thread overview]
Message-ID: <51D71A4C.2000709@hunenet.nl> (raw)
In-Reply-To: <20130705105442.GA9050@zion.uk.xensource.com>
On 07/05/2013 12:54 PM, Wei Liu wrote:
>>
>> [ 7.670132] Adding 4192252k swap on /dev/xvda1. Priority:-1
>> extents:1 across:4192252k SS
>> [ 10.204340] NET: Registered protocol family 17
>> [ 481.534979] netfront: Too many frags
>> [ 487.543946] netfront: Too many frags
>> [ 491.049458] netfront: Too many frags
>> [ 491.491153] ------------[ cut here ]------------
>> [ 491.491628] kernel BUG at drivers/xen/netfront/netfront.c:1295!
>
> So what's the code around line 1295? There must be a BUG_ON there. It's
> normal you didn't see the same line number in my patch (1306) because we
> were using different kernel.
>
Yes, stupid me. I was definitely in a wrong state when writing this.
Even more stupid, I did make the same stupid remark after obtaining
results with Jan's patch. 1000 times sorry... ( I was to much in a hurry
to get my response back to you likely because I was happy that you guys
could free some for this.)
So now we know that nr_frags >= MAX_SKB_FRAGS
1285 static RING_IDX xennet_fill_frags(struct netfront_info *np,
1286 struct sk_buff *skb,
1287 struct sk_buff_head *list)
1288 {
1289 struct skb_shared_info *shinfo = skb_shinfo(skb);
1290 int nr_frags = shinfo->nr_frags;
1291 RING_IDX cons = np->rx.rsp_cons;
1292 struct sk_buff *nskb;
1293
1294 while ((nskb = __skb_dequeue(list))) {
1295 BUG_ON(nr_frags >= MAX_SKB_FRAGS);
1296
1297 struct netif_rx_response *rx =
1298 RING_GET_RESPONSE(&np->rx, ++cons);
1299
>>
>> In the mean time Jan took the bug in bugzilla
>> (https://bugzilla.novell.com/show_bug.cgi?id=826374) and created a first
>> patch. I propose we continue the discussion there and post the
>> conclusion in this list to finish this thread here as well.
>>
>
> I'm not so sure what's the best way. In general it would be much a
> burden for developers to look at every bugzilla, let alone register
> account for each bugzilla.
>
> Anyway, as we already started the discussion here, I think we should
> just continue it here. We could do this the other way around, discuss
> here and post conclusion / references there.
This is oke with me. I was wondering what would be most convenient.
Dion
next prev parent reply other threads:[~2013-07-05 19:11 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8511913.uMAmUdIO30@eistomin.edss.local>
2013-05-17 8:59 ` [Xen-users] kernel 3.9.2 - xen 4.2.2/4.3rc1 => BUG unable to handle kernel paging request netif_poll+0x49c/0xe8 Wei Liu
2013-05-17 9:08 ` Jan Beulich
2013-05-17 9:37 ` Eugene Istomin
2013-05-17 9:40 ` Eugene Istomin
2013-05-17 10:45 ` Jan Beulich
2013-05-17 12:03 ` Eugene Istomin
2013-05-17 12:25 ` Jan Beulich
2013-05-17 12:30 ` Eugene Istomin
2013-05-17 12:36 ` Jan Beulich
2013-05-17 12:52 ` Eugene Istomin
2013-05-17 13:00 ` Eugene Istomin
2013-05-18 10:06 ` Eugene Istomin
2013-05-20 6:52 ` Eugene Istomin
2013-05-20 8:58 ` Ian Campbell
2013-05-20 9:06 ` Wei Liu
2013-05-20 9:17 ` Eugene Istomin
2013-05-20 9:24 ` Wei Liu
2013-05-21 9:55 ` Jan Beulich
2013-05-21 11:09 ` Eugene Istomin
2013-05-21 11:49 ` Jan Beulich
2013-05-21 16:19 ` Eugene Istomin
2013-05-31 3:37 ` Eugene Istomin
2013-05-31 6:19 ` Jan Beulich
2013-05-31 6:22 ` Eugene Istomin
2013-05-31 8:20 ` Wei Liu
2013-05-21 15:28 ` Wei Liu
2013-05-31 15:47 ` Wei Liu
2013-05-31 16:00 ` Jan Beulich
2013-05-31 16:05 ` Wei Liu
2013-07-04 13:43 ` Dion Kant
2013-07-04 14:18 ` Jan Beulich
2013-07-04 15:01 ` Wei Liu
2013-07-05 9:32 ` [PATCH] xen-netfront: pull on receive skb may need to happen earlier Jan Beulich
2013-07-05 14:53 ` Wei Liu
2013-07-05 14:53 ` Wei Liu
2013-07-07 1:10 ` David Miller
2013-07-07 1:10 ` David Miller
2013-07-08 9:59 ` Jan Beulich
2013-07-08 12:16 ` Dion Kant
2013-07-08 12:41 ` Jan Beulich
2013-07-08 12:41 ` Jan Beulich
2013-07-08 14:20 ` [Xen-devel] " Jan Beulich
2013-07-08 15:22 ` Eric Dumazet
2013-07-08 15:22 ` [Xen-devel] " Eric Dumazet
2013-07-09 7:47 ` Jan Beulich
2013-07-09 7:47 ` Jan Beulich
2013-07-08 15:48 ` [Xen-devel] " Wei Liu
2013-07-09 6:52 ` Jan Beulich
2013-07-09 6:52 ` [Xen-devel] " Jan Beulich
2013-07-09 16:51 ` Wei Liu
2013-07-09 16:51 ` [Xen-devel] " Wei Liu
2013-07-10 6:58 ` Jan Beulich
2013-07-10 6:58 ` [Xen-devel] " Jan Beulich
2013-07-10 10:04 ` Wei Liu
2013-07-10 10:04 ` [Xen-devel] " Wei Liu
2013-07-10 10:46 ` Jan Beulich
2013-07-10 12:50 ` Ian Campbell
2013-07-10 12:53 ` Wei Liu
2013-07-10 12:53 ` Wei Liu
2013-07-10 13:58 ` Jan Beulich
2013-07-10 13:58 ` [Xen-devel] " Jan Beulich
2013-07-10 12:50 ` Ian Campbell
2013-07-10 10:46 ` Jan Beulich
2013-07-10 13:19 ` [Xen-devel] " Eric Dumazet
2013-07-10 13:19 ` Eric Dumazet
2013-07-08 15:48 ` Wei Liu
2013-07-12 8:32 ` [Xen-devel] " Wei Liu
2013-07-12 8:56 ` Jan Beulich
2013-07-13 11:26 ` Dion Kant
2013-07-13 11:26 ` [Xen-devel] " Dion Kant
2013-07-13 20:17 ` Dion Kant
2013-07-15 6:37 ` Jan Beulich
2013-07-12 8:56 ` Jan Beulich
2013-07-12 8:32 ` Wei Liu
2013-07-08 14:20 ` Jan Beulich
2013-07-08 9:59 ` Jan Beulich
2013-07-05 9:32 ` Jan Beulich
2013-07-05 9:36 ` kernel 3.9.2 - xen 4.2.2/4.3rc1 => BUG unable to handle kernel paging request netif_poll+0x49c/0xe8 Jan Beulich
2013-07-05 10:40 ` [Xen-users] " Dion Kant
2013-07-05 10:54 ` Wei Liu
2013-07-05 19:11 ` Dion Kant [this message]
2013-07-05 10:56 ` Jan Beulich
2013-07-05 19:46 ` Dion Kant
2013-07-06 13:36 ` Wei Liu
2013-07-08 8:25 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D71A4C.2000709@hunenet.nl \
--to=g.w.kant@hunenet.nl \
--cc=jbeulich@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.