From mboxrd@z Thu Jan 1 00:00:00 1970 From: Abbas Raza Subject: Re: [PATCH] drm: drm init call takes large time Date: Tue, 09 Jul 2013 01:26:15 +0500 Message-ID: <51DB2067.1040808@mentor.com> References: <1372552919-7791-1-git-send-email-abbas_raza@mentor.com> <20130702101444.GK5004@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from relay1.mentorg.com (relay1.mentorg.com [192.94.38.131]) by gabe.freedesktop.org (Postfix) with ESMTP id A0746E5DE4 for ; Mon, 8 Jul 2013 13:26:20 -0700 (PDT) In-Reply-To: <20130702101444.GK5004@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: =?ISO-8859-1?Q?Ville_Syrj=E4l=E4?= Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 07/02/2013 03:14 PM, Ville Syrj=E4l=E4 wrote: > On Sun, Jun 30, 2013 at 05:41:59AM +0500, Abbas Raza wrote: >> From: Abbas Raza >> >> DRM_INFO calls in the drm init routines are causing a large delay at boo= t time >> due to which imx_drm_init call average takes around 26 ms. Changing DRM_= INFO to >> DRM_DEBUG reduces startup time to < 3ms. > = > Serial console enabled? > = > Not that I think these printks are particularly useful... Yes serial console is enabled. these printk's seem useful but they take lot= of time, increasing the boot time. > = >> Signed-off-by: Abbas Raza >> CC: David Airlie >> Acked-by: Dmitry Eremin-Solenikov >> --- >> drivers/gpu/drm/drm_irq.c | 6 +++--- >> drivers/gpu/drm/drm_platform.c | 2 +- >> 2 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c >> index c798eea..782f5ff 100644 >> --- a/drivers/gpu/drm/drm_irq.c >> +++ b/drivers/gpu/drm/drm_irq.c >> @@ -252,13 +252,13 @@ int drm_vblank_init(struct drm_device *dev, int nu= m_crtcs) >> if (!dev->_vblank_time) >> goto err; >> = >> - DRM_INFO("Supports vblank timestamp caching Rev 1 (10.10.2010).\n"); >> + DRM_DEBUG("Supports vblank timestamp caching Rev 1 (10.10.2010).\n"); >> = >> /* Driver specific high-precision vblank timestamping supported? */ >> if (dev->driver->get_vblank_timestamp) >> - DRM_INFO("Driver supports precise vblank timestamp query.\n"); >> + DRM_DEBUG("Driver supports precise vblank timestamp query.\n"); >> else >> - DRM_INFO("No driver support for vblank timestamp query.\n"); >> + DRM_DEBUG("No driver support for vblank timestamp query.\n"); >> = >> /* Zero per-crtc vblank stuff */ >> for (i =3D 0; i < num_crtcs; i++) { >> diff --git a/drivers/gpu/drm/drm_platform.c b/drivers/gpu/drm/drm_platfo= rm.c >> index 82431dc..7649963 100644 >> --- a/drivers/gpu/drm/drm_platform.c >> +++ b/drivers/gpu/drm/drm_platform.c >> @@ -92,7 +92,7 @@ int drm_get_platform_dev(struct platform_device *platd= ev, >> = >> mutex_unlock(&drm_global_mutex); >> = >> - DRM_INFO("Initialized %s %d.%d.%d %s on minor %d\n", >> + DRM_DEBUG("Initialized %s %d.%d.%d %s on minor %d\n", >> driver->name, driver->major, driver->minor, driver->patchlevel, >> driver->date, dev->primary->index); >> = >> -- = >> 1.8.2 >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/dri-devel > = Thanks . Abbas Raza