Re: /sys/module/pcie_aspm/parameters/policy not writable?

[Robert Hancock <hancockrwd@gmail.com>]

On 07/09/2013 03:49 AM, Pavel Machek wrote:
> On Mon 2013-07-08 21:13:21, Greg KH wrote:
>> On Tue, Jul 09, 2013 at 03:26:11AM +0200, Pavel Machek wrote:
>>> Hi!
>>>
>>> My thinkpad has rather high ping latencies... and perhaps it is due to
>>> PCIE ASPM.
>>
>> Why would that be the problem?  The odds that the PCIE bus is the issue
>> seems strange to me.
>
> Aha: I guess that's why the file is not writable:
>
> pavel@amd:~$ dmesg | grep -i aspm
> ACPI FADT declares the system doesn't support PCIe ASPM, so disable it

IIRC, this message is somewhat misleading. When that FADT flag is set by 
the BIOS, the kernel doesn't so much disable ASPM as disable the 
kernel's control over ASPM. I believe this was to match Windows behavior.

> e1000e 0000:02:00.0: Disabling ASPM L0s L1

And given that, I think this message may also be misleading, as the 
kernel won't touch the device's ASPM state. Force-enabling ASPM may 
actually be allowing the driver to disable ASPM on the device.

I seem to recall a recent thread on this about another device.. maybe we 
need to allow drivers to explicitly disable ASPM if it's enabled even if 
the FADT flag is set?

> pavel@amd:~$ cat /sys/module/pcie_aspm/parameters/policy
> [default] performance powersave
> pavel@amd:~$
> root@amd:~# echo -n performance >
> /sys/module/pcie_aspm/parameters/policy
> -su: echo: write error: Operation not permitted
> root@amd:~#
>
> But:
> 1) it should not list unavailable options
>
> 2) operation not permitted seems like wrong error code for
> operation not supported.
>
> 									Pavel
>