From: "Andreas Färber" <afaerber@suse.de>
To: peter.crosthwaite@xilinx.com
Cc: devel@thom.fr.eu.org, Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH arm-devs v1 1/2] hw/timer: Introduce ARM A9 Global Timer.
Date: Wed, 10 Jul 2013 10:25:35 +0200 [thread overview]
Message-ID: <51DD1A7F.1040809@suse.de> (raw)
In-Reply-To: <CAFEAcA8MYogkOc+Vz_5U9rr82r+X=TG68RuRfhUMU3B-y8Lz1g@mail.gmail.com>
Am 10.07.2013 09:41, schrieb Peter Maydell:
> On 10 July 2013 06:08, <peter.crosthwaite@xilinx.com> wrote:
>> From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>>
>> The ARM A9 MPCore has a timer that is global to all CPUs in the mpcore.
>> The timer is shared but each CPU has a private independent comparator
>> and interrupt.
>>
>> Original version contributed by Francois LEGAL.
>>
>> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>> ---
>> Francois, do you want to re-add your SOB? I have changed the device
>> a lot since your V2.
If you have a DCO for a patch you're reusing, you should never "drop" it
from your patch. You can still leave the textual explanation there.
> The usual way to indicate this (assuming Francois signed off the
> original patchset) is something like:
>
> Signed-off-by: Original Author
> [You: <short description of subsequent changes>]
> Signed-off-by: Your Name
Add to that, the difference between From and SOB indicates that you did
more than just cosmetic touches. For example, when I wrote from scratch
a new SoC QOM object I used my From and the original author's Sob (to
put the blame on me while recording the DCO), whereas when I purely
updated code to MemoryRegions, Coding Style, QOM casts, etc. I use the
original author's From and [AF: ...].
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-07-10 8:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 5:08 [Qemu-devel] [PATCH arm-devs v1 1/2] hw/timer: Introduce ARM A9 Global Timer peter.crosthwaite
2013-07-10 5:08 ` [Qemu-devel] [PATCH arm-devs v1 2/2] cpu/a9mpcore: Add " peter.crosthwaite
2013-07-10 7:41 ` [Qemu-devel] [PATCH arm-devs v1 1/2] hw/timer: Introduce ARM A9 " Peter Maydell
2013-07-10 8:25 ` Andreas Färber [this message]
2013-07-10 14:07 ` Peter Crosthwaite
2013-07-10 14:56 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DD1A7F.1040809@suse.de \
--to=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=devel@thom.fr.eu.org \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.