From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753382Ab3GJIlt (ORCPT ); Wed, 10 Jul 2013 04:41:49 -0400 Received: from multi.imgtec.com ([194.200.65.239]:8146 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751097Ab3GJIlq (ORCPT ); Wed, 10 Jul 2013 04:41:46 -0400 Message-ID: <51DD1E0F.80101@imgtec.com> Date: Wed, 10 Jul 2013 09:40:47 +0100 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Rusty Russell CC: Kees Cook , , , David Woodhouse , Subject: Re: [RESEND][PATCH] mtd: refactor call to request_module References: <20130708130512.GA24315@www.outflux.net> <87hag3cdp0.fsf@rustcorp.com.au> In-Reply-To: <87hag3cdp0.fsf@rustcorp.com.au> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.65] X-SEF-Processed: 7_3_0_01192__2013_07_10_09_41_41 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/07/13 04:10, Rusty Russell wrote: > Kees Cook writes: >> This reduces the size of the stack frame when calling request_module(). >> Performing the sprintf before the call is not needed. >> >> Signed-off-by: Kees Cook > > Acked-by: Rusty Russell I remember reviewing this before, so feel free to add my: Reviewed-by: James Hogan Cheers James From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from multi.imgtec.com ([194.200.65.239]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UwpyR-0005by-G5 for linux-mtd@lists.infradead.org; Wed, 10 Jul 2013 08:42:08 +0000 Message-ID: <51DD1E0F.80101@imgtec.com> Date: Wed, 10 Jul 2013 09:40:47 +0100 From: James Hogan MIME-Version: 1.0 To: Rusty Russell Subject: Re: [RESEND][PATCH] mtd: refactor call to request_module References: <20130708130512.GA24315@www.outflux.net> <87hag3cdp0.fsf@rustcorp.com.au> In-Reply-To: <87hag3cdp0.fsf@rustcorp.com.au> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: linux-mtd@lists.infradead.org, akpm@linux-foundation.org, David Woodhouse , Kees Cook , linux-kernel@vger.kernel.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 10/07/13 04:10, Rusty Russell wrote: > Kees Cook writes: >> This reduces the size of the stack frame when calling request_module(). >> Performing the sprintf before the call is not needed. >> >> Signed-off-by: Kees Cook > > Acked-by: Rusty Russell I remember reviewing this before, so feel free to add my: Reviewed-by: James Hogan Cheers James