From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH] tools/xl: Add 'xen_version' to `xl info` Date: Thu, 11 Jul 2013 10:21:24 +0100 Message-ID: <51DE7914.7070403@eu.citrix.com> References: <1373474790-31760-1-git-send-email-andrew.cooper3@citrix.com> <51DE7674.8010508@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51DE7674.8010508@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Ian Jackson , Ian Campbell , Xen-devel List-Id: xen-devel@lists.xenproject.org On 11/07/13 10:10, Andrew Cooper wrote: > On 11/07/13 10:02, George Dunlap wrote: >> On Wed, Jul 10, 2013 at 5:46 PM, Andrew Cooper >> wrote: >>> Getting the full Xen version in an easily scriptable way is awkward, >>> especially if trying to piece together from xen_{major,minor,extra}. >>> >>> This reflects $(XEN_FULLVERSION) in the build system (but under a more >>> sensible name, as $(XEN_VERSION) is just the major number). >>> >>> Signed-off-by: Andrew Cooper >> I can see the point, but it seems a bit redundant to have the version >> info printed twice. >> >> This makes me wonder if it might make sense to have options to print >> just individual items; e.g.: >> >> xl info --xen_version >> >> or perhaps >> >> xi info --format="%{xen_version}" >> >> or something. >> >> -George > Ah - that was part 2 which I am working on in my copious free time. > > At the moment, xl info takes no parameters, or an -h or -n. > > I was thinking it could be modifed to optionally take a positional > paramater, such as > > xl info xen_version > > Even with this however, my original point still stands. Getting the > version number is awkward. Is there actually a reason to print it separately at all? Why not replace the individual lines with the unified line? -George