From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wen Congyang <wency@cn.fujitsu.com>
Subject: Re: [RFC Patch v2 10/16] colo: implement
 restore_callbacks finish_restore()
Date: Thu, 11 Jul 2013 17:54:02 +0800
Message-ID: <51DE80BA.5000603@cn.fujitsu.com>
References: <1373531748-12547-1-git-send-email-wency@cn.fujitsu.com>	<1373531748-12547-11-git-send-email-wency@cn.fujitsu.com>
	<1373535641.5453.154.camel@hastur.hellion.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1373535641.5453.154.camel@hastur.hellion.org.uk>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>, Jiang Yunhong <yunhong.jiang@intel.com>, Dong Eddie <eddie.dong@intel.com>, Ye Wei <wei.ye1987@gmail.com>, xen-devl <xen-devel@lists.xen.org>, Hong Tao <bobby.hong@huawei.com>, Xu Yao <xuyao.xu@huawei.com>, Shriram Rajagopalan <rshriram@cs.ubc.ca>
List-Id: xen-devel@lists.xenproject.org

At 07/11/2013 05:40 PM, Ian Campbell Wrote:
> On Thu, 2013-07-11 at 16:35 +0800, Wen Congyang wrote:
>> [...]
>> diff --git a/tools/libxc/Makefile b/tools/libxc/Makefile
>> index 70994b9..92d11af 100644
>> --- a/tools/libxc/Makefile
>> +++ b/tools/libxc/Makefile
>> @@ -49,7 +49,7 @@ GUEST_SRCS-y += xc_nomigrate.c
>>  endif
>>  
>>  vpath %.c ../../xen/common/libelf
>> -CFLAGS += -I../../xen/common/libelf
>> +CFLAGS += -I../../xen/common/libelf -I../xenstore
> 
> We have avoided needing libxc to speak xenstore so far.

OK. I will fix it in the next version.

> 
> It looks like you only use xs_suspend_evtchn_port, in which case you
> could just pass this from libxc's caller.
> 
>> [...]
> 
>> +    if (colo_data->first_time) {
>> +        sleep(10);
> 
> This can't be right, can it?

Yes, just to wait suspend evtchn port. I will cleanup it in the next version.

Thanks

> 
> Ian.
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>