From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Subject: Re: [Qemu-devel] [PULL 09/43] cpu: Make first_cpu and next_cpu CPUState Date: Thu, 11 Jul 2013 11:55:43 +0200 Message-ID: <51DE811F.3000802@suse.de> References: <1373466860-32732-1-git-send-email-afaerber@suse.de> <1373466860-32732-10-git-send-email-afaerber@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: qemu-devel , Peter Maydell , Evgeny Voevodin , Luiz Capitulino , Peter Crosthwaite , "Edgar E. Iglesias" , Igor Mitsyanko , Gleb Natapov , Alexander Graf , Maksim Kozlov , Riku Voipio , Paul Brook , kvm , Scott Wood , Anthony Liguori , Mark Langsdorf , Marcelo Tosatti , qemu-ppc , Dmitry Solodkiy , Paolo Bonzini , Aurelien Jarno To: TeLeMan Return-path: Received: from cantor2.suse.de ([195.135.220.15]:38059 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751478Ab3GKJzw (ORCPT ); Thu, 11 Jul 2013 05:55:52 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Am 11.07.2013 11:14, schrieb TeLeMan: > On Wed, Jul 10, 2013 at 10:33 PM, Andreas F=C3=A4rber wrote: >> diff --git a/gdbstub.c b/gdbstub.c >> index f7d9f13..0ee82a9 100644 >> --- a/gdbstub.c >> +++ b/gdbstub.c [...] >> @@ -2394,7 +2401,7 @@ static int gdb_handle_packet(GDBState *s, cons= t char *line_buf) >> put_packet(s, "QC1"); >> break; >> } else if (strcmp(p,"fThreadInfo") =3D=3D 0) { >> - s->query_cpu =3D first_cpu; >> + s->query_cpu =3D first_cpu->env_ptr; >> goto report_cpuinfo; >> } else if (strcmp(p,"sThreadInfo") =3D=3D 0) { >> report_cpuinfo: >> @@ -2402,7 +2409,7 @@ static int gdb_handle_packet(GDBState *s, cons= t char *line_buf) >> snprintf(buf, sizeof(buf), "m%x", >> cpu_index(ENV_GET_CPU(s->query_cpu))); >> put_packet(s, buf); >> - s->query_cpu =3D s->query_cpu->next_cpu; >> + s->query_cpu =3D ENV_GET_CPU(s->query_cpu)->next_cp= u->env_ptr; > next_cpu may be NULL. True. If this is the only place where you've found that mistake then th= e implicit fix is already queued next on qom-cpu: http://patchwork.ozlabs.org/patch/255756/ Review and/or testing of the remaining gdbstub patches would be appreci= ated: http://lists.nongnu.org/archive/html/qemu-devel/2013-07/msg01510.html Mainly I'm waiting on an ack or feedback for the vaddr typedef to proce= ed. Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3= =BCrnberg From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UxDbO-0003sp-K3 for qemu-devel@nongnu.org; Thu, 11 Jul 2013 05:55:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UxDbM-0007cy-TU for qemu-devel@nongnu.org; Thu, 11 Jul 2013 05:55:54 -0400 Message-ID: <51DE811F.3000802@suse.de> Date: Thu, 11 Jul 2013 11:55:43 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1373466860-32732-1-git-send-email-afaerber@suse.de> <1373466860-32732-10-git-send-email-afaerber@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 09/43] cpu: Make first_cpu and next_cpu CPUState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: TeLeMan Cc: Peter Maydell , Anthony Liguori , Marcelo Tosatti , Igor Mitsyanko , Gleb Natapov , Evgeny Voevodin , Riku Voipio , qemu-devel , Luiz Capitulino , Peter Crosthwaite , Mark Langsdorf , Alexander Graf , qemu-ppc , Paul Brook , kvm , Paolo Bonzini , Scott Wood , "Edgar E. Iglesias" , Maksim Kozlov , Aurelien Jarno , Dmitry Solodkiy Am 11.07.2013 11:14, schrieb TeLeMan: > On Wed, Jul 10, 2013 at 10:33 PM, Andreas F=C3=A4rber wrote: >> diff --git a/gdbstub.c b/gdbstub.c >> index f7d9f13..0ee82a9 100644 >> --- a/gdbstub.c >> +++ b/gdbstub.c [...] >> @@ -2394,7 +2401,7 @@ static int gdb_handle_packet(GDBState *s, const = char *line_buf) >> put_packet(s, "QC1"); >> break; >> } else if (strcmp(p,"fThreadInfo") =3D=3D 0) { >> - s->query_cpu =3D first_cpu; >> + s->query_cpu =3D first_cpu->env_ptr; >> goto report_cpuinfo; >> } else if (strcmp(p,"sThreadInfo") =3D=3D 0) { >> report_cpuinfo: >> @@ -2402,7 +2409,7 @@ static int gdb_handle_packet(GDBState *s, const = char *line_buf) >> snprintf(buf, sizeof(buf), "m%x", >> cpu_index(ENV_GET_CPU(s->query_cpu))); >> put_packet(s, buf); >> - s->query_cpu =3D s->query_cpu->next_cpu; >> + s->query_cpu =3D ENV_GET_CPU(s->query_cpu)->next_cpu-= >env_ptr; > next_cpu may be NULL. True. If this is the only place where you've found that mistake then the implicit fix is already queued next on qom-cpu: http://patchwork.ozlabs.org/patch/255756/ Review and/or testing of the remaining gdbstub patches would be appreciat= ed: http://lists.nongnu.org/archive/html/qemu-devel/2013-07/msg01510.html Mainly I'm waiting on an ack or feedback for the vaddr typedef to proceed= . Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg