From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 11/11] ARM: shmobile: bockw: add USB Function support
Date: Thu, 11 Jul 2013 11:46:37 +0000 [thread overview]
Message-ID: <51DE9B1D.6070000@cogentembedded.com> (raw)
In-Reply-To: <877ggxfqbr.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 11-07-2013 12:34, Kuninori Morimoto wrote:
> Bock-W USB1 (CN29) can be USB Host/Func by SW98/SW99 settings.
> USB Func will be enabled if CONFIG_USB_RENESAS_USBHS_UDC[_MODULE]
> was selected on this patch
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> arch/arm/mach-shmobile/board-bockw.c | 80 ++++++++++++++++++++++++++++++--
> arch/arm/mach-shmobile/clock-r8a7778.c | 1 +
> 2 files changed, 78 insertions(+), 3 deletions(-)
> diff --git a/arch/arm/mach-shmobile/board-bockw.c b/arch/arm/mach-shmobile/board-bockw.c
> index 8978f61..a005fba 100644
> --- a/arch/arm/mach-shmobile/board-bockw.c
> +++ b/arch/arm/mach-shmobile/board-bockw.c
[...]
> @@ -62,6 +63,16 @@
> * SW19 (MMC) 1 pin
> */
> > @@ -276,6 +345,11 @@ static void __init bockw_init(void)
> }
> }
>
> +static void __init bockw_init_late(void)
> +{
You're not registering USB host devices now at all. NAK.
> + ADD_USB_FUNC_DEVICE_IF_POSSIBLE;
> +}
> +
WBR, Sergei
prev parent reply other threads:[~2013-07-11 11:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 8:34 [PATCH 11/11] ARM: shmobile: bockw: add USB Function support Kuninori Morimoto
2013-07-11 11:46 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DE9B1D.6070000@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.