From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ming Lei <ming.lei@canonical.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, Oliver Neukum <oliver@neukum.org>,
Alan Stern <stern@rowland.harvard.edu>,
linux-input@vger.kernel.org, linux-bluetooth@vger.kernel.org,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-media@vger.kernel.org, alsa-devel@alsa-project.org,
Clemens Ladisch <clemens@ladisch.de>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 46/50] Sound: usb: ua101: spin_lock in complete() cleanup
Date: Thu, 11 Jul 2013 17:10:51 +0400 [thread overview]
Message-ID: <51DEAEDB.2060600@cogentembedded.com> (raw)
In-Reply-To: <1373533573-12272-47-git-send-email-ming.lei@canonical.com>
On 11-07-2013 13:06, Ming Lei wrote:
Here the subject doesn't match the patch.
> Complete() will be run with interrupt enabled, so disable local
> interrupt before holding a global lock which is held without irqsave.
> Cc: Clemens Ladisch <clemens@ladisch.de>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: alsa-devel@alsa-project.org
> Signed-off-by: Ming Lei <ming.lei@canonical.com>
> ---
> sound/usb/misc/ua101.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
> diff --git a/sound/usb/misc/ua101.c b/sound/usb/misc/ua101.c
> index 8b5d2c5..52a60c6 100644
> --- a/sound/usb/misc/ua101.c
> +++ b/sound/usb/misc/ua101.c
> @@ -613,14 +613,24 @@ static int start_usb_playback(struct ua101 *ua)
>
> static void abort_alsa_capture(struct ua101 *ua)
> {
> - if (test_bit(ALSA_CAPTURE_RUNNING, &ua->states))
> + if (test_bit(ALSA_CAPTURE_RUNNING, &ua->states)) {
> + unsigned long flags;
> +
> + local_irq_save(flags);
> snd_pcm_stop(ua->capture.substream, SNDRV_PCM_STATE_XRUN);
> + local_irq_restore(flags);
> + }
> }
>
> static void abort_alsa_playback(struct ua101 *ua)
> {
> - if (test_bit(ALSA_PLAYBACK_RUNNING, &ua->states))
> + if (test_bit(ALSA_PLAYBACK_RUNNING, &ua->states)) {
> + unsigned long flags;
> +
> + local_irq_save(flags);
> snd_pcm_stop(ua->playback.substream, SNDRV_PCM_STATE_XRUN);
> + local_irq_restore(flags);
> + }
> }
WBR, Sergei
next prev parent reply other threads:[~2013-07-11 13:10 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 9:05 [PATCH 00/50] USB: cleanup spin_lock in URB->complete() Ming Lei
2013-07-11 9:05 ` [PATCH 01/50] USB: devio: spin_lock in complete() cleanup Ming Lei
2013-07-11 9:05 ` [PATCH 02/50] USB: cdc-wdm: " Ming Lei
2013-07-11 9:05 ` Ming Lei
2013-07-11 9:05 ` [PATCH 03/50] USB: usblp: " Ming Lei
2013-07-11 9:05 ` [PATCH 04/50] USB: adutux: " Ming Lei
2013-07-11 9:05 ` [PATCH 05/50] USB: misc: uss720: " Ming Lei
2013-07-11 12:15 ` Sergei Shtylyov
2013-07-11 12:15 ` Sergei Shtylyov
2013-07-11 9:05 ` [PATCH 06/50] USB: iowarrior: " Ming Lei
2013-07-11 9:05 ` [PATCH 07/50] USB: ldusb: " Ming Lei
2013-07-11 9:05 ` Ming Lei
2013-07-11 9:05 ` [PATCH 08/50] USB: legousbtower: " Ming Lei
2013-07-11 12:18 ` Sergei Shtylyov
2013-07-11 12:18 ` Sergei Shtylyov
2013-07-11 12:36 ` Oliver Neukum
2013-07-11 13:47 ` Sergei Shtylyov
2013-07-11 12:42 ` Ming Lei
2013-07-11 12:42 ` Ming Lei
2013-07-11 9:05 ` [PATCH 09/50] USB: usbtest: " Ming Lei
2013-07-11 9:05 ` [PATCH 10/50] USB: serial: cyberjack: " Ming Lei
2013-07-11 9:05 ` [PATCH 11/50] USB: serial: digi_acceleportldusb: " Ming Lei
2013-07-11 9:05 ` [PATCH 12/50] USB: serial: io_edgeport: " Ming Lei
2013-07-11 9:05 ` [PATCH 13/50] USB: serial: io_ti: " Ming Lei
2013-07-11 9:05 ` [PATCH 14/50] USB: serial: mos7720: " Ming Lei
2013-07-11 9:05 ` Ming Lei
2013-07-11 9:05 ` [PATCH 15/50] USB: serial: mos77840: " Ming Lei
2013-07-11 9:05 ` [PATCH 16/50] USB: serial: quatech2: " Ming Lei
2013-07-11 9:05 ` [PATCH 17/50] USB: serial: sierra: " Ming Lei
2013-07-11 13:02 ` Sergei Shtylyov
2013-07-11 9:05 ` [PATCH 18/50] USB: serial: symbolserial: " Ming Lei
2013-07-11 9:05 ` [PATCH 19/50] USB: serial: ti_usb_3410_5052: " Ming Lei
2013-07-11 9:05 ` [PATCH 20/50] USB: serial: usb_wwan: " Ming Lei
2013-07-11 9:05 ` Ming Lei
2013-07-11 9:05 ` [PATCH 21/50] hid: usbhid: " Ming Lei
2013-07-11 9:05 ` [PATCH 22/50] BT: btusb: " Ming Lei
2013-07-11 9:05 ` [PATCH 23/50] BT: bfusb: read_lock " Ming Lei
2013-07-11 9:05 ` [PATCH 24/50] input: cm109: spin_lock " Ming Lei
2013-07-11 9:05 ` [PATCH 25/50] ISDN: hfcsusb: " Ming Lei
2013-07-11 9:05 ` [PATCH 26/50] USBNET: cdc-phonet: " Ming Lei
2013-07-11 9:05 ` Ming Lei
2013-07-11 9:05 ` [PATCH 27/50] USBNET: hso: " Ming Lei
2013-07-11 9:05 ` Ming Lei
2013-07-11 9:05 ` [PATCH 28/50] USBNET: kaweth: " Ming Lei
2013-07-11 9:05 ` Ming Lei
2013-07-11 9:05 ` [PATCH 29/50] USBNET: rtl8150: " Ming Lei
2013-07-11 9:05 ` Ming Lei
2013-07-11 9:05 ` [PATCH 30/50] wireless: ath9k: " Ming Lei
2013-07-11 9:05 ` [PATCH 31/50] wireless: zd1211rw: " Ming Lei
2013-07-11 9:05 ` [PATCH 32/50] wireless: ath: carl9170: " Ming Lei
2013-07-11 9:05 ` [PATCH 33/50] wireless: libertas: " Ming Lei
2013-07-11 9:05 ` [PATCH 34/50] wireless: libertas_tf: " Ming Lei
2013-07-11 9:05 ` [PATCH 35/50] media: usb: cx231xx: " Ming Lei
2013-07-26 14:28 ` Hans Verkuil
2013-07-27 9:34 ` Ming Lei
2013-07-11 9:05 ` [PATCH 36/50] media: usb: em28xx: " Ming Lei
2013-07-11 12:42 ` Devin Heitmueller
2013-07-11 9:06 ` [PATCH 37/50] media: usb: sn9x102: " Ming Lei
2013-07-11 9:06 ` [PATCH 38/50] media: usb: tlg2300: " Ming Lei
2013-07-11 9:06 ` [PATCH 39/50] media: usb: tm6000: " Ming Lei
2013-07-11 9:06 ` [PATCH 40/50] media: dvb-core: " Ming Lei
2013-07-11 9:06 ` [PATCH 41/50] media: usb: em28xx: make sure irq disabled before acquiring lock Ming Lei
2013-07-11 9:06 ` [PATCH 42/50] media: usb: tlg2300: spin_lock in complete() cleanup Ming Lei
2013-07-11 13:13 ` Sergei Shtylyov
2013-07-11 9:06 ` [PATCH 43/50] sound: usb: midi: " Ming Lei
2013-07-11 9:06 ` [PATCH 44/50] sound: usb: caiaq: " Ming Lei
2013-07-11 13:12 ` Sergei Shtylyov
2013-07-11 14:06 ` Daniel Mack
2013-07-11 9:06 ` [PATCH 45/50] sound: usb: usx2y: " Ming Lei
2013-07-11 13:08 ` Sergei Shtylyov
2013-07-11 13:50 ` Takashi Iwai
2013-07-11 13:50 ` Takashi Iwai
2013-07-11 14:13 ` Ming Lei
2013-07-11 14:34 ` Takashi Iwai
2013-07-11 14:34 ` Takashi Iwai
2013-07-11 14:52 ` Ming Lei
2013-07-11 9:06 ` [PATCH 46/50] Sound: usb: ua101: " Ming Lei
2013-07-11 9:06 ` Ming Lei
2013-07-11 13:10 ` Sergei Shtylyov [this message]
2013-07-11 9:06 ` [PATCH 47/50] staging: btmtk_usb: " Ming Lei
2013-07-11 9:06 ` Ming Lei
2013-07-11 9:06 ` [PATCH 48/50] staging: bcm: " Ming Lei
2013-07-11 9:06 ` [PATCH 49/50] staging: ced1401: " Ming Lei
2013-07-11 9:06 ` [PATCH 50/50] staging: vt6656: " Ming Lei
2013-07-14 13:17 ` [PATCH 00/50] USB: cleanup spin_lock in URB->complete() Andy Walls
2013-07-14 14:33 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DEAEDB.2060600@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=perex@perex.cz \
--cc=stern@rowland.harvard.edu \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.