All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: akpm@linux-foundation.org, kosaki.motohiro@jp.fujitsu.com,
	kamezawa.hiroyu@jp.fujitsu.com, linux-mm@kvack.org
Subject: Re: [-] drop_caches-add-some-documentation-and-info-messsge.patch removed from -mm tree
Date: Thu, 11 Jul 2013 08:45:23 -0700	[thread overview]
Message-ID: <51DED313.6050900@intel.com> (raw)
In-Reply-To: <20130711154249.GL21667@dhcp22.suse.cz>

On 07/11/2013 08:42 AM, Michal Hocko wrote:
> On Thu 11-07-13 08:34:45, Dave Hansen wrote:
>> On 07/11/2013 05:39 AM, Michal Hocko wrote:
>>>> I would turn this into a trace point but that would be much weaker
>>>> because the one who is debugging an issue would have to think about
>>>> enabling it before the affected workload starts. Which is not possible
>>>> quite often. Having logs and looking at them afterwards is so
>>>> _convinient_.
>>
>> It would also be a lot weaker than the printk, but we could always add a
>> counter for this stuff and at least dump it out in /proc/vmstat.  We
>> wouldn't know who was doing it, but we'd at least know someone _was_
>> doing it.  It would also have a decent chance of getting picked up by
>> existing log collection systems.
> 
> But wouldn't be a counter more intrusive code wise? Dunno, but printk
> serves it purpose and it doesn't add much to the code.

Yeah, I prefer the printk too.  I'd rather see a vmstat entry than a
tracepoint, though.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2013-07-11 15:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10 20:25 [-] drop_caches-add-some-documentation-and-info-messsge.patch removed from -mm tree akpm
2013-07-11  7:36 ` Michal Hocko
2013-07-11 12:39   ` Michal Hocko
2013-07-11 15:34     ` Dave Hansen
2013-07-11 15:42       ` Michal Hocko
2013-07-11 15:45         ` Dave Hansen [this message]
2013-07-11 21:50   ` Andrew Morton
2013-07-12 11:50     ` Michal Hocko
2013-07-12 12:25       ` Borislav Petkov
2013-07-12 19:08       ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51DED313.6050900@intel.com \
    --to=dave.hansen@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.