All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Murphy <dmurphy@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [[PATCH v3 2/2] gpio: omap5-uevm: Configure the tca6424 gpio expander
Date: Fri, 12 Jul 2013 12:30:36 -0500	[thread overview]
Message-ID: <51E03D3C.8040104@ti.com> (raw)
In-Reply-To: <CAGo_u6rTY_f5bU4RDMwrKvZQr04JOGYk_vbCLr-Eaj=w2OQa6A@mail.gmail.com>

NM

On 07/11/2013 01:02 PM, Nishanth Menon wrote:
<snip>
>>> diff --git a/board/ti/omap5_uevm/mux_data.h
> b/board/ti/omap5_uevm/mux_data.h
>>>> index a82795d..7e6415e 100644
>>>> --- a/board/ti/omap5_uevm/mux_data.h
>>>> +++ b/board/ti/omap5_uevm/mux_data.h
>>>> @@ -56,6 +56,8 @@ const struct pad_conf_entry
> core_padconf_array_essential[] = {
>>>>       {USBD0_HS_DP, (IEN | M0)},    /*  USBD0_HS_DP */
>>>>       {USBD0_HS_DM, (IEN | M0)},    /*  USBD0_HS_DM */
>>>>       {USBD0_SS_RX, (IEN | M0)},    /*  USBD0_SS_RX */
>>>> +    {I2C5_SCL, (IEN | M0)}, /* I2C5_SCL */
>>> nit pick -> SCL (or i2c clk) is out put from master - always. IEN
> enables full duplex, but anyways.. just a nitpick :)
>> OK I changed this and did a test and reads fail without the IEN set.
>> This is to sync the client clocks.
> Scl? I2c clock? Does not work without input- something is fishy no?
Nope.  There is clock synchronization and clock arbitration that happens and the I2C master needs to see the SCL as an input.

Kernel configures the I2C mux for 1 and 5 the same way.
<snip>

-- 
------------------
Dan Murphy

  reply	other threads:[~2013-07-12 17:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10 20:06 [U-Boot] [[PATCH v3 1/2] gpio: tca642x: Add the tca642x gpio expander driver Dan Murphy
2013-07-10 20:06 ` [U-Boot] [[PATCH v3 2/2] gpio: omap5-uevm: Configure the tca6424 gpio expander Dan Murphy
2013-07-10 23:56   ` Nishanth Menon
2013-07-11 14:30     ` Tom Rini
2013-07-11 15:10       ` Dan Murphy
2013-07-11 15:55     ` Dan Murphy
2013-07-11 18:02       ` Nishanth Menon
2013-07-12 17:30         ` Dan Murphy [this message]
2013-07-12 21:55           ` Nishanth Menon
2013-07-11 14:31 ` [U-Boot] [[PATCH v3 1/2] gpio: tca642x: Add the tca642x gpio expander driver Tom Rini
2013-07-11 15:11   ` Dan Murphy
2013-07-11 18:10 [U-Boot] [PATCH " Dan Murphy
2013-07-11 18:10 ` [U-Boot] [PATCH v3 2/2] gpio: omap5-uevm: Configure the tca6424 gpio expander Dan Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E03D3C.8040104@ti.com \
    --to=dmurphy@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.