From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chad Versace <chad.versace@linux.intel.com>
Subject: Re: [PATCH] [v2] drm/i915: Expose LLC size to user space
Date: Fri, 12 Jul 2013 10:38:01 -0700
Message-ID: <51E03EF9.2000809@linux.intel.com>
References: <1373425083-1276-1-git-send-email-ben@bwidawsk.net>
	<1373568732-3061-1-git-send-email-ben@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
	by gabe.freedesktop.org (Postfix) with ESMTP id 1D61CE5BF9
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 12 Jul 2013 10:38:04 -0700 (PDT)
In-Reply-To: <1373568732-3061-1-git-send-email-ben@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>, Bryan Bell <bryan.j.bell@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On 07/11/2013 11:52 AM, Ben Widawsky wrote:
> The algorithm/information was originally written by Chad, though I
> changed the control flow, and I think his original code had a couple of
> bugs, though I didn't look very hard before rewriting. That could have
> also been different interpretations of the spec.
>
> I've tested this on two platforms, and it seems to perform how I want.
>
> With this patch is a small tool for igt to query the size. This can be
> used as a reference for DRI clients wishing to query the information.
>
> v2: Update name of the SDM location (Bryan)
> Dissent: Use a new param instead of reusing HAS_LLC param (Chris, Chad)
> Fix unicode multiply symbol (Ben)
>
> CC: Chad Versace <chad.versace@linux.intel.com>
> CC: Bryan Bell <bryan.j.bell@intel.com>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
> ---
>   drivers/gpu/drm/i915/i915_dma.c |  3 +++
>   drivers/gpu/drm/i915/i915_drv.h |  2 ++
>   drivers/gpu/drm/i915/i915_gem.c | 55 +++++++++++++++++++++++++++++++++++++++++
>   include/uapi/drm/i915_drm.h     |  1 +
>   4 files changed, 61 insertions(+)

As long as this is tested and returns the same as L3 in /proc/cpuinfo, this patch is
Reviewed-by: Chad Versace <chad.versace@linux.intel.com>