From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyMG6-0002FA-E9 for qemu-devel@nongnu.org; Sun, 14 Jul 2013 09:22:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UyMG5-0001z9-J0 for qemu-devel@nongnu.org; Sun, 14 Jul 2013 09:22:38 -0400 Received: from mail-pb0-f44.google.com ([209.85.160.44]:57746) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UyMG5-0001yh-D2 for qemu-devel@nongnu.org; Sun, 14 Jul 2013 09:22:37 -0400 Received: by mail-pb0-f44.google.com with SMTP id uo1so10405986pbc.3 for ; Sun, 14 Jul 2013 06:22:35 -0700 (PDT) Message-ID: <51E2A614.5010402@ozlabs.ru> Date: Sun, 14 Jul 2013 23:22:28 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1373614639-15523-1-git-send-email-aik@ozlabs.ru> <20130713080309.GA11522@voom.redhat.com> In-Reply-To: <20130713080309.GA11522@voom.redhat.com> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spapr-pci: change endianness for io ports space List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf On 07/13/2013 06:03 PM, David Gibson wrote: > On Fri, Jul 12, 2013 at 05:37:19PM +1000, Alexey Kardashevskiy wrote: >> sPAPR PHB emulates IO ports on PCI via a special memory region which >> routes all reads/writes further via cpu_in*/cpu_out* which are eventually >> processed by MemoryRegionOps implemented by devices. > Hrm. That double dispatch was a workaround for bugs in the plain > memory region dispatching which meant we couldn't directly map regions > in memory space to IO areas. > > It would be worth checking if that workaround is still necessary. Hm. Good point, thanks! It seems memory_region_init_io is not necessary any more. Will make a patch for it. -- Alexey