From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH] xen: allow architecture to choose whether
 to compress installed xen binary
Date: Mon, 15 Jul 2013 10:44:51 +0100
Message-ID: <51E3E0B302000078000E4DEA@nat28.tlf.novell.com>
References: <1373630398-20993-1-git-send-email-ijc@hellion.org.uk>
	<1373877510-18967-1-git-send-email-ijc@hellion.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1373877510-18967-1-git-send-email-ijc@hellion.org.uk>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ijc@hellion.org.uk>
Cc: keir@xen.org, Ian Campbell <ian.campbell@citrix.com>, stefano.stabellini@eu.citrix.com, tim@xen.org, xen-devel@lists.xen.org, julien.grall@citrix.com
List-Id: xen-devel@lists.xenproject.org

>>> On 15.07.13 at 10:38, Ian Campbell <ijc@hellion.org.uk> wrote:
> This is a follow up to "xen: arm: make zImage the default target which we
> install".
> 
> On ARM the xen.gz binary installed into /boot is not immediately useful 
> because
> bootloaders (e.g. u-boot) do not unconditionally support decompression 
> (except
> via the uImage wrapper, which we currently do not support via our build 
> system)

There are two changes I'd like to suggest:

> --- a/config/arm32.mk
> +++ b/config/arm32.mk
> @@ -2,6 +2,8 @@ CONFIG_ARM := y
>  CONFIG_ARM_32 := y
>  CONFIG_ARM_$(XEN_OS) := y
>  
> +CONFIG_INSTALL_COMPRESSED_XEN := n

Rename it suitably, leave it empty for ARM and set it to .gz on x86,
allowing it to also be used for other purposes (like a different
suffix if e.g. another compression method is supported on some
platform).

> -_install: $(TARGET).gz
> +_install: $(TARGET)$(GZ)
>  	[ -d $(DESTDIR)/boot ] || $(INSTALL_DIR) $(DESTDIR)/boot
> -	$(INSTALL_DATA) $(TARGET).gz $(DESTDIR)/boot/$(notdir 
> $(TARGET))-$(XEN_FULLVERSION).gz
> -	ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION).gz $(DESTDIR)/boot/$(notdir 
> $(TARGET))-$(XEN_VERSION).$(XEN_SUBVERSION).gz
> -	ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION).gz $(DESTDIR)/boot/$(notdir 
> $(TARGET))-$(XEN_VERSION).gz
> -	ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION).gz $(DESTDIR)/boot/$(notdir 
> $(TARGET)).gz
> +	$(INSTALL_DATA) $(TARGET)$(GZ) $(DESTDIR)/boot/$(notdir 
> $(TARGET))-$(XEN_FULLVERSION)$(GZ)
> +	ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION)$(GZ) $(DESTDIR)/boot/$(notdir 
> $(TARGET))-$(XEN_VERSION).$(XEN_SUBVERSION)$(GZ)
> +	ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION)$(GZ) $(DESTDIR)/boot/$(notdir 
> $(TARGET))-$(XEN_VERSION)$(GZ)
> +	ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION)$(GZ) $(DESTDIR)/boot/$(notdir 

As you're touching this block already, let's drop the .gz extension
on the destination altogether - under /boot that's pretty
meaningless anyway.

Jan