All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] dfu, nand, ubi: add partubi alt settings for updating ubi partition
Date: Tue, 16 Jul 2013 07:11:04 +0200	[thread overview]
Message-ID: <51E4D5E8.6000308@denx.de> (raw)
In-Reply-To: <201307160700.57788.marex@denx.de>

Hello Marek,

Am 16.07.2013 07:00, schrieb Marek Vasut:
> Dear Heiko Schocher,
>
>> updating an ubi partition needs a completely erased mtd partition,
>> see:
>> http://lists.infradead.org/pipermail/linux-mtd/2011-May/035416.html
>>
>> So, add partubi alt setting for the dfu_alt_info environment
>> variable to mark this partition as an ubi partition. In case we
>> update an ubi partition, we erase after flashing the image into the
>> partition, the remaining sektors.
>>
>> Signed-off-by: Heiko Schocher<hs@denx.de>
>> Cc: Pantelis Antoniou<panto@antoniou-consulting.com>
>> Cc: Tom Rini<trini@ti.com>
>> Cc: Lukasz Majewski<l.majewski@samsung.com>
>> Cc: Kyungmin Park<kyungmin.park@samsung.com>
>> Cc: Marek Vasut<marex@denx.de>
>> Cc: Wolfgang Denk<wd@denx.de>
>>
>> ---
>>
>> - This patch is also a good starting point to fix up updating ubi, as
>>    we currently use "nand erase" for erasing the sektors. This is
>>    not the prefered way for writing an ubi image, see:
>>    http://www.linux-mtd.infradead.org/faq/ubi.html#L_flash_img
>>
>>    This must be fixed ... we have no "ubiformat" in u-boot, or?
>>
>> - changes for v2:
>>    - do not use spread = 1 for nand_erase_opts, to prevent
>>      errormessage if there are bad blocks in the erase range.
>> ---
>>   drivers/dfu/dfu.c      | 30 +++++++++++++++++++++++++++++-
>>   drivers/dfu/dfu_nand.c | 26 ++++++++++++++++++++++++++
>>   include/dfu.h          |  2 ++
>>   3 Dateien ge?ndert, 57 Zeilen hinzugef?gt(+), 1 Zeile entfernt(-)
>>
>> diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c
>> index 0521752..7ba7026 100644
>> --- a/drivers/dfu/dfu.c
>> +++ b/drivers/dfu/dfu.c
>> @@ -23,6 +23,7 @@
>>   #include<errno.h>
>>   #include<malloc.h>
>>   #include<mmc.h>
>> +#include<nand.h>
>>   #include<fat.h>
>>   #include<dfu.h>
>>   #include<linux/list.h>
>> @@ -176,6 +177,34 @@ int dfu_write(struct dfu_entity *dfu, void *buf, int
>> size, int blk_seq_num) ret = dfu->flush_medium(dfu);
>>   		printf("\nDFU complete CRC32: 0x%08x\n", dfu->crc);
>>
>> +		/* in case of ubi partition, erase rest of the partition */
>> +		if (dfu->ubi == 1) {
>> +			int ret;
>> +			nand_info_t *nand;
>> +			/* erase complete partition */
>> +			nand_erase_options_t opts;
>> +
>> +			if (nand_curr_device<  0 ||
>> +			    nand_curr_device>= CONFIG_SYS_MAX_NAND_DEVICE ||
>> +			    !nand_info[nand_curr_device].name) {
>> +				printf("%s: invalid nand device\n", __func__);
>> +				return -1;
>> +			}
>> +
>> +			nand =&nand_info[nand_curr_device];
>> +
>> +			memset(&opts, 0, sizeof(opts));
>> +			opts.offset = dfu->data.nand.start + dfu->offset +
>> +					dfu->bad_skip;
>> +			opts.length = dfu->data.nand.start +
>> +					dfu->data.nand.size - opts.offset;
>> +			ret = nand_erase_opts(nand,&opts);
>> +			if (ret != 0) {
>> +				printf("Failure erase: %d\n", ret);
>> +				return ret;
>
> Are you not leaking memory here ? I suspect you should call dfu_free_buf() as
> below ?

Yes, fixed. Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2013-07-16  5:11 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-15  9:49 [U-Boot] [PATCH 1/2] dfu, nand, ubi: add partubi alt settings for updating ubi partition Heiko Schocher
2013-07-16  4:54 ` [U-Boot] [PATCH v2] " Heiko Schocher
2013-07-16  5:00   ` Marek Vasut
2013-07-16  5:11     ` Heiko Schocher [this message]
2013-07-16  7:41   ` Lukasz Majewski
2013-07-16  8:01     ` Heiko Schocher
2013-07-16  8:19       ` Lukasz Majewski
2013-07-16 15:14   ` Tom Rini
2013-07-16 15:43     ` Heiko Schocher
2013-07-17 22:35   ` Scott Wood
2013-07-18  5:01     ` Heiko Schocher
2013-07-18  6:04   ` [U-Boot] [PATCH v3] " Heiko Schocher
2013-07-18  6:57     ` Lukasz Majewski
2013-07-22 21:08       ` Scott Wood
2013-07-19  4:32     ` [U-Boot] [PATCH v4] " Heiko Schocher
2013-07-19  6:45       ` Lukasz Majewski
2013-07-19 13:54         ` Marek Vasut
2013-07-22 21:24       ` Scott Wood
2013-07-23 13:12         ` Heiko Schocher
2013-07-23 23:13           ` Scott Wood
2013-07-23 23:22       ` Scott Wood
2013-07-24  4:30         ` Heiko Schocher
2013-07-24 19:08           ` Scott Wood
2013-07-25  4:34             ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E4D5E8.6000308@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.