From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uz3Gw-00028X-Hr for qemu-devel@nongnu.org; Tue, 16 Jul 2013 07:18:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uz3Gt-00051Z-TN for qemu-devel@nongnu.org; Tue, 16 Jul 2013 07:18:22 -0400 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:58935 helo=mx01.kamp.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1Uz3Gt-00051L-Hj for qemu-devel@nongnu.org; Tue, 16 Jul 2013 07:18:19 -0400 Message-ID: <51E52BF8.1000005@kamp.de> Date: Tue, 16 Jul 2013 13:18:16 +0200 From: Peter Lieven MIME-Version: 1.0 References: <1373885375-13601-1-git-send-email-pl@kamp.de> <51E526B3.9070203@redhat.com> In-Reply-To: <51E526B3.9070203@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] qemu-img: conditionally discard target on convert List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, qemu-devel@nongnu.org, stefanha@redhat.com On 16.07.2013 12:55, Paolo Bonzini wrote: > Il 15/07/2013 12:49, Peter Lieven ha scritto: >> this adds the proposed solution to add a generic mechanism to zeroize >> a target in qemu-img if it has discard_zeroes but has_zero_init is 0. >> >> Peter Lieven (4): >> block: add discard_zeroes and max_unmap to BlockDriverInfo >> iscsi: add .bdrv_get_info >> block/raw: add .bdrv_get_info >> qemu-img: conditionally discard target on convert >> >> block/iscsi.c | 19 +++++++++++++++-- >> block/raw.c | 6 ++++++ >> include/block/block.h | 5 +++++ >> qemu-img.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++- >> 4 files changed, 83 insertions(+), 3 deletions(-) >> > Looks good. Perhaps, as a followup, you can use max_unmap (which I'd > rename to max_discard) in bdrv_co_discard to support splitting the > request. You could also export the discard alignment in BlockDriverInfo. I already did this in my previous series for iscsi. But I can also add a follow up if in the future another driver specifies max_discard. I will drop it from iscsi again then. Before this patch here is merged, we need the other series "[PATCHv3 00/10] iscsi/qemu-img/block-migration enhancements" otherwise patch 2/4 will not apply. Maybe you can put it together again or I will do a v4 with all patches together. Thanks, Peter