All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Ian Campbell <ijc@hellion.org.uk>
Cc: julien.grall@citrix.com, tim@xen.org, xen-devel@lists.xen.org,
	keir@xen.org, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH] xen: allow architecture to choose whether to compress installed xen binary
Date: Tue, 16 Jul 2013 10:20:50 +0100	[thread overview]
Message-ID: <51E52C9202000078000E5405@nat28.tlf.novell.com> (raw)
In-Reply-To: <1373966142.4663.17.camel@kazak.uk.xensource.com>

>>> On 16.07.13 at 11:15, Ian Campbell <ijc@hellion.org.uk> wrote:
> On Mon, 2013-07-15 at 10:44 +0100, Jan Beulich wrote:
>> >>> On 15.07.13 at 10:38, Ian Campbell <ijc@hellion.org.uk> wrote:
>> > This is a follow up to "xen: arm: make zImage the default target which we
>> > install".
>> > 
>> > On ARM the xen.gz binary installed into /boot is not immediately useful 
>> > because
>> > bootloaders (e.g. u-boot) do not unconditionally support decompression 
>> > (except
>> > via the uImage wrapper, which we currently do not support via our build 
>> > system)
>> 
>> There are two changes I'd like to suggest:
>> 
>> > --- a/config/arm32.mk
>> > +++ b/config/arm32.mk
>> > @@ -2,6 +2,8 @@ CONFIG_ARM := y
>> >  CONFIG_ARM_32 := y
>> >  CONFIG_ARM_$(XEN_OS) := y
>> >  
>> > +CONFIG_INSTALL_COMPRESSED_XEN := n
>> 
>> Rename it suitably, leave it empty for ARM and set it to .gz on x86,
>> allowing it to also be used for other purposes (like a different
>> suffix if e.g. another compression method is supported on some
>> platform).
> 
> Heh, my first (unposted) version did exactly that but I decided people
> would prefer this way as a less intrusive change. I will change it back
> and use CONFIG_INSTALL_XEN_SUFFIX perhaps?

Yes, please.

>> > -_install: $(TARGET).gz
>> > +_install: $(TARGET)$(GZ)
>> >  	[ -d $(DESTDIR)/boot ] || $(INSTALL_DIR) $(DESTDIR)/boot
>> > -	$(INSTALL_DATA) $(TARGET).gz $(DESTDIR)/boot/$(notdir 
>> > $(TARGET))-$(XEN_FULLVERSION).gz
>> > -	ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION).gz 
> $(DESTDIR)/boot/$(notdir 
>> > $(TARGET))-$(XEN_VERSION).$(XEN_SUBVERSION).gz
>> > -	ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION).gz 
> $(DESTDIR)/boot/$(notdir 
>> > $(TARGET))-$(XEN_VERSION).gz
>> > -	ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION).gz 
> $(DESTDIR)/boot/$(notdir 
>> > $(TARGET)).gz
>> > +	$(INSTALL_DATA) $(TARGET)$(GZ) $(DESTDIR)/boot/$(notdir 
>> > $(TARGET))-$(XEN_FULLVERSION)$(GZ)
>> > +	ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION)$(GZ) 
> $(DESTDIR)/boot/$(notdir 
>> > $(TARGET))-$(XEN_VERSION).$(XEN_SUBVERSION)$(GZ)
>> > +	ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION)$(GZ) 
> $(DESTDIR)/boot/$(notdir 
>> > $(TARGET))-$(XEN_VERSION)$(GZ)
>> > +	ln -f -s $(notdir $(TARGET))-$(XEN_FULLVERSION)$(GZ) 
> $(DESTDIR)/boot/$(notdir 
>> 
>> As you're touching this block already, let's drop the .gz extension
>> on the destination altogether - under /boot that's pretty
>> meaningless anyway.
> 
> I'm slightly concerned about breaking bootloaders (or more specifically
> their tooling like update-grub, grubby etc) here. I'm happy to make the
> change but would prefer to do it as a separate patch (which negates your
> "As you're touching" comment).

Fine with me.

Jan

  reply	other threads:[~2013-07-16  9:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-12 11:59 [PATCH] xen: arm: make zImage the default target which we install Ian Campbell
2013-07-15  8:38 ` [PATCH] xen: allow architecture to choose whether to compress installed xen binary Ian Campbell
2013-07-15  9:44   ` Jan Beulich
2013-07-16  9:15     ` Ian Campbell
2013-07-16  9:20       ` Jan Beulich [this message]
2013-07-17 11:13         ` Ian Campbell
2013-07-17 11:31           ` Jan Beulich
2013-07-17 11:37             ` Ian Campbell
2013-07-17 11:13         ` [PATCH] xen: x86: drop the ".gz" suffix when installing Ian Campbell
2013-07-17 11:26           ` Jan Beulich
2013-07-17 11:35             ` Ian Campbell
2013-07-18 12:05 ` [PATCH] xen: arm: make zImage the default target which we install Julien Grall
2013-07-18 12:10   ` Ian Campbell
2013-07-18 12:12     ` Julien Grall
2013-07-19 14:18       ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51E52C9202000078000E5405@nat28.tlf.novell.com \
    --to=jbeulich@suse.com \
    --cc=ijc@hellion.org.uk \
    --cc=julien.grall@citrix.com \
    --cc=keir@xen.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.